Reformat code after updating golangci linter #4099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4099 +/- ##
==========================================
- Coverage 75.85% 74.74% -1.11%
==========================================
Files 347 347
Lines 22195 22194 -1
==========================================
- Hits 16836 16589 -247
- Misses 4031 4319 +288
+ Partials 1328 1286 -42
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
approved these changes
Feb 20, 2024
AlekSi
requested changes
Feb 20, 2024
There was a problem hiding this comment.
As you can see, the linter does not complain on CI: https://github.com/FerretDB/FerretDB/actions/runs/7966637338/job/21748215090
That's because origin/main is up-to-date there. If you see linter errors in this file locally, that's because your branches are not in sync. Please understand how new-from-rev option works.
This code is being rewritten in my branch anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix everything the linter complains about.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.