Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fields to requests and responses #4096

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Add more fields to requests and responses #4096

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e3b2821
Add logicalSessionTimeoutMinutes to isMaster response
rumyantseva Feb 19, 2024
cedf227
wip
rumyantseva Feb 19, 2024
3afd7d5
Merge branch 'main' into logicalSessionTimeoutMinutes
Feb 19, 2024
00c1a3f
wip
rumyantseva Feb 19, 2024
24fd256
wip
rumyantseva Feb 19, 2024
24ff71d
wip
rumyantseva Feb 19, 2024
0356104
wip
rumyantseva Feb 19, 2024
4bdda45
wip
rumyantseva Feb 19, 2024
ce34d38
wip
rumyantseva Feb 19, 2024
eb25b42
Merge branch 'main' into logicalSessionTimeoutMinutes
Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add logicalSessionTimeoutMinutes to isMaster response
  • Loading branch information
@rumyantseva
rumyantseva committed Feb 19, 2024
commit e3b282172feed44ae83cc747c1b226c7aa508636
4 changes: 2 additions & 2 deletions internal/handler/common/ismaster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
return &reply, nil
}

// IsMasterDocuments returns isMaster's Documents field (identical for both OP_MSG and OP_QUERY).
// IsMasterDocument returns isMaster's Documents field (identical for both OP_MSG and OP_QUERY).
func IsMasterDocument(tcpHost, name string) *types.Document {
doc := must.NotFail(types.NewDocument(
"ismaster", true, // only lowercase
Expand All @@ -48,7 +48,7 @@
"maxMessageSizeBytes", int32(wire.MaxMsgLen),
"maxWriteBatchSize", int32(100000),
"localTime", time.Now(),
// logicalSessionTimeoutMinutes
"logicalSessionTimeoutMinutes", int32(30),

Check warning on line 51 in internal/handler/common/ismaster.go

View check run for this annotation

Codecov / codecov/patch

internal/handler/common/ismaster.go#L51 

Added line #L51 was not covered by tests
"connectionId", int32(42),
"minWireVersion", MinWireVersion,
"maxWireVersion", MaxWireVersion,
Expand Down
Loading