Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups #4046

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Minor cleanups #4046

merged 7 commits into from
Feb 8, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Feb 7, 2024 •
edited
Loading

Description

Bump dependencies and port small changes from other PRs.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Feb 7, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (fed2380) 74.72% compared to head (379f950) 74.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
- Coverage   74.72%   74.54%   -0.19%     
==========================================
  Files         341      341              
  Lines       27423    21750    -5673     
==========================================
- Hits        20493    16213    -4280     
+ Misses       5634     4288    -1346     
+ Partials     1296     1249      -47
Files Coverage Δ
integration/setup/helpers.go 78.78% <100.00%> (+13.57%) ⬆️
internal/util/must/must.go 33.33% <0.00%> (-9.53%) ⬇️
internal/bson2/document.go 50.00% <0.00%> (+4.01%) ⬆️
internal/clientconn/conn.go 51.36% <53.84%> (-4.67%) ⬇️

... and 315 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.74% <44.44%> (-0.25%) ⬇️
hana-1 ?
integration 66.74% <44.44%> (-0.25%) ⬇️
mongodb-1 4.82% <14.81%> (-0.14%) ⬇️
postgresql-1 49.67% <44.44%> (+0.69%) ⬆️
postgresql-2 46.61% <44.44%> (+0.35%) ⬆️
postgresql-3 47.86% <44.44%> (+0.59%) ⬆️
sqlite-1 49.01% <44.44%> (+0.60%) ⬆️
sqlite-2 45.75% <44.44%> (+0.38%) ⬆️
sqlite-3 47.08% <44.44%> (+0.61%) ⬆️
unit 32.45% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Feb 8, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Feb 8, 2024
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Feb 8, 2024
@AlekSi AlekSi marked this pull request as ready for review February 8, 2024 05:37
@AlekSi AlekSi requested a review from a team as a code owner February 8, 2024 05:37
@AlekSi AlekSi enabled auto-merge (squash) February 8, 2024 05:37
@AlekSi AlekSi requested review from a team, henvic and noisersup February 8, 2024 05:38
chilagrow
chilagrow approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, thank you for updating dependencies 🤗

internal/clientconn/conn.go Show resolved Hide resolved
@AlekSi AlekSi disabled auto-merge February 8, 2024 06:09
@AlekSi AlekSi merged commit 282c8e1 into FerretDB:main Feb 8, 2024
29 of 31 checks passed
@AlekSi AlekSi deleted the small-cleanups branch February 8, 2024 06:09
henvic pushed a commit to henvic/FerretDB that referenced this pull request Feb 8, 2024
@AlekSi @henvic
Minor cleanups (FerretDB#4046)
b67ff41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@henvic henvic Awaiting requested review from henvic henvic was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @chilagrow