Add user commands to handler map #3918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3918 +/- ##
==========================================
- Coverage 75.22% 73.83% -1.40%
==========================================
Files 330 330
Lines 25665 25677 +12
==========================================
- Hits 19306 18958 -348
- Misses 5210 5588 +378
+ Partials 1149 1131 -18
... and 26 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
requested changes
Jan 1, 2024
Comment on lines
+80
to
+83
| "createUser": { | ||
| Handler: h.MsgCreateUser, | ||
| Help: "Creates a new user on the database where you run the command.", | ||
| }, |
There was a problem hiding this comment.
Those commands are listed down below inside of EnablenewAuth if, so I assume they should be only accessible when running FerretDB with -test-enable-new-auth, i can be wrong though
There was a problem hiding this comment.
You are correct indeed!
|
Commands exist with |
auto-merge was automatically disabled
January 1, 2024 20:14
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the handler commands map for commands that were implemented in #1491, #3866, and #3867.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.