Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for cursor not found #3768

Closed
wants to merge 19 commits into from
Closed

Add an integration test for cursor not found #3768

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
520d323
add a stress test
b1ron Nov 28, 2023
aa6af74
Merge branch 'main' into st-cursor-not-found
b1ron Nov 28, 2023
8f005fd
needs a running process
b1ron Nov 28, 2023
7d7359e
set small batch size
b1ron Nov 28, 2023
d91595a
use large documents
b1ron Nov 28, 2023
c0b8efc
not a true test
b1ron Nov 30, 2023
e41eeb3
use getMore
b1ron Nov 30, 2023
038072a
two clients
b1ron Nov 30, 2023
ea5dbc8
still not correct
b1ron Dec 1, 2023
ae27da7
RunCommandCursor creates a new cursor so do not use it
b1ron Dec 1, 2023
8432d79
add a test for zero ID
b1ron Dec 1, 2023
8bdacfa
connect
b1ron Dec 1, 2023
47503f7
tweak
b1ron Dec 1, 2023
fb94454
works as expected
b1ron Dec 4, 2023
d6b23ad
skip
b1ron Dec 4, 2023
5eb48c9
word it better
b1ron Dec 4, 2023
62a32d6
Merge branch 'main' into st-cursor-not-found
b1ron Dec 4, 2023
021db95
dot
b1ron Dec 4, 2023
a4c3358
Merge branch 'main' into st-cursor-not-found
AlekSi Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a test for zero ID
  • Loading branch information
@b1ron
b1ron committed Dec 1, 2023
commit 8432d79670ac8f6f606e0abca35452b0442fe033
62 changes: 39 additions & 23 deletions integration/cursor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (

"github.com/AlekSi/pointer"
"github.com/FerretDB/FerretDB/integration/setup"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.mongodb.org/mongo-driver/bson"
"go.mongodb.org/mongo-driver/mongo"
Expand Down Expand Up @@ -57,39 +58,54 @@ func TestCursor(t *testing.T) {

collection2 := client2.Database(databaseName).Collection(collectionName)

arr, _ := generateDocuments(0, 100)
arr, _ := generateDocuments(0, 2)
_, err = collection2.InsertMany(ctx, arr)
require.NoError(t, err)

cur, err := collection2.Find(ctx, bson.D{}, opts)
require.NoError(t, err)
t.Run("CursorNotFoundAfterDisconnect", func(t *testing.T) {
cur, err := collection2.Find(ctx, bson.D{}, opts)
require.NoError(t, err)

cursorID := cur.ID()

cursorID := cur.ID()
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()

var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
command := bson.D{
{"getMore", cursorID},
{"collection", collection1.Name()},
}

command := bson.D{
{"getMore", cursorID},
{"collection", collection1.Name()},
}
for {
result := bson.M{}
err := collection1.Database().RunCommand(ctx, command).Decode(result)
if errors.Is(err, mongo.ErrNoDocuments) {
break
}

for {
result := bson.M{}
err := collection1.Database().RunCommand(ctx, command).Decode(result)
require.NoError(t, err)
require.NoError(t, err)

if errors.Is(err, mongo.ErrNoDocuments) {
break
}
}

}()
}()

err = client2.Disconnect(ctx)
require.NoError(t, err)
err = client2.Disconnect(ctx)
require.NoError(t, err)

wg.Wait()
wg.Wait()
})

t.Run("CursorClosedAfterIDZero", func(t *testing.T) {
// test if an additional getMore is needed when the cursor ID is 0
cur, err := collection2.Find(ctx, bson.D{}, opts)
require.NoError(t, err)

cur.Next(ctx)
cur.Next(ctx)

assert.False(t, cur.Next(ctx))
assert.Equal(t, int64(0), cur.ID())
})
}
Loading