Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an integration test for cursor not found #3768

Closed
wants to merge 19 commits into from
Closed

Add an integration test for cursor not found #3768

wants to merge 19 commits into from

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Nov 28, 2023 •
edited
Loading

Description

Closes #3739.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron self-assigned this Nov 28, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3db735b) 75.66% compared to head (a4c3358) 31.36%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3768       +/-   ##
===========================================
- Coverage   75.66%   31.36%   -44.30%     
===========================================
  Files         325      309       -16     
  Lines       24873    23612     -1261     
===========================================
- Hits        18820     7407    -11413     
- Misses       4942    15512    +10570     
+ Partials     1111      693      -418

see 190 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true ?
hana-1 ?
integration ?
mongodb-1 ?
mysql-1 ?
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sqlite-1 ?
sqlite-2 ?
sqlite-3 ?
unit 31.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron changed the title Add a stress test for cursors Add an integration test for cursor not found Nov 30, 2023
@b1ron
Copy link
Contributor Author

b1ron commented Nov 30, 2023 •
edited
Loading

@AlekSi I am able to reproduce the error here but there's also a corresponding MongoDB error which doesn't happen in the dance failure.

So, I do not think this is a valid test.

AlekSi
AlekSi reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test uses a single client connection.

See TestGetMoreCommandConnection for an example

@AlekSi
Copy link
Member

AlekSi commented Dec 7, 2023

Please merge it into #3823

@AlekSi
Copy link
Member

AlekSi commented Dec 21, 2023

@noisersup please move what is needed to #3884 and close this PR

@AlekSi AlekSi assigned noisersup and unassigned b1ron Dec 21, 2023
@noisersup
Copy link
Member

#3893

@noisersup noisersup closed this Dec 21, 2023
@noisersup noisersup deleted the st-cursor-not-found branch December 21, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi left review comments

Assignees

@noisersup noisersup

Labels
None yet
Projects
Current Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate CursorNotFound error
3 participants
@b1ron @AlekSi @noisersup