Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explain panic for non-existent collection on PostgreSQL #3541

Merged
merged 10 commits into from
Oct 13, 2023
Merged

Fix explain panic for non-existent collection on PostgreSQL #3541

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
735485c
wip?
noisersup Oct 10, 2023
9d05557
wip
noisersup Oct 10, 2023
88bc561
wip
noisersup Oct 11, 2023
560e3ae
wip
noisersup Oct 11, 2023
ce7e391
wip
noisersup Oct 11, 2023
e997e12
wip
noisersup Oct 11, 2023
ee744a3
Merge branch 'main' into fix-explain-panic
noisersup Oct 11, 2023
9b539c1
Merge branch 'main' into fix-explain-panic
AlekSi Oct 12, 2023
2ce1f86
wip
noisersup Oct 12, 2023
968f779
Merge branch 'main' into fix-explain-panic
AlekSi Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip
  • Loading branch information
@noisersup
noisersup committed Oct 11, 2023
commit 88bc561237320a3893e16990b3b89eb0f002bf90
1 change: 0 additions & 1 deletion internal/handlers/registry/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ type TestOpts struct {

// NewHandler constructs a new handler.
func NewHandler(name string, opts *NewHandlerOpts) (handlers.Interface, error) {
opts.UseNewPG = true
if opts == nil {
return nil, fmt.Errorf("opts is nil")
}
Expand Down
4 changes: 0 additions & 4 deletions internal/handlers/sqlite/msg_explain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@ func (h *Handler) MsgExplain(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg,
return nil, lazyerrors.Error(err)
}

//TODO
if res.QueryPlanner == nil {
}

var reply wire.OpMsg
must.NoError(reply.SetSections(wire.OpMsgSection{
Documents: []*types.Document{must.NotFail(types.NewDocument(
Expand Down
Loading