Implement filter pushdown for SQLite #3337
Closed
+254
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3337 +/- ##
==========================================
- Coverage 74.44% 69.26% -5.18%
==========================================
Files 422 417 -5
Lines 26375 26163 -212
==========================================
- Hits 19635 18122 -1513
- Misses 5617 6925 +1308
+ Partials 1123 1116 -7
... and 103 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
force-pushed
the
sqlite-pushdown-3235
branch
from
de5f004 to
a590e63
Compare
AlekSi
reviewed
Sep 25, 2023
integration/pushdown.go
Outdated
Comment on lines
28
to
30
| noPushdown resultPushdown = 1 << iota // 0000 0000 | ||
| pgPushdown // 0000 0001 | ||
| sqlitePushdown // 0000 0010 |
There was a problem hiding this comment.
Those comments are not actually correct. It is better to check them in the init function
integration/pushdown.go
Outdated
Comment on lines
43
to
48
| case setup.IsSQLite(t): | ||
| return res&sqlitePushdown == sqlitePushdown | ||
| case setup.IsPostgres(t): | ||
| return res&pgPushdown == pgPushdown | ||
| case setup.IsMongoDB(t): | ||
| return false |
There was a problem hiding this comment.
Let's use consistent order: PostgreSQL, SQLite, other backends, MongoDB
integration/setup/test_helpers.go
Outdated
| // IsPostgres returns true if the current test is running for pg handler. | ||
| // | ||
| // This function should not be used lightly. | ||
| func IsPostgres(tb testtb.TB) bool { |
There was a problem hiding this comment.
Move it up to preserve the order
|
@noisersup this pull request has merge conflicts. |
AlekSi
reviewed
Sep 27, 2023
|
@noisersup this pull request has merge conflicts. |
|
@noisersup this pull request has merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3235.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.