Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new PostgreSQL backend stub #3319

Merged
merged 53 commits into from
Sep 10, 2023
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
2cbcb3b
Add dummy decorator
AlekSi Sep 4, 2023
a16d4ca
Improve dummy
AlekSi Sep 4, 2023
7855c79
Tweak timestamp
AlekSi Sep 4, 2023
67c174f
Add basic oplog decorator
AlekSi Sep 4, 2023
4f2add7
Clean-up `*types.Timestamp` a bit
AlekSi Sep 4, 2023
75fdd96
Merge branch 'timestamp' into decorators
AlekSi Sep 4, 2023
d433561
Make it kinda work
AlekSi Sep 4, 2023
3e8dd1f
Fix
AlekSi Sep 5, 2023
757874e
Merge branch 'timestamp' into decorators
AlekSi Sep 5, 2023
5532b29
Merge branch 'main' into decorators
AlekSi Sep 5, 2023
47bcc04
Enable MongoDB OpLog
AlekSi Sep 5, 2023
ceac70d
Enable OpLog in MongoDB
AlekSi Sep 5, 2023
d14b858
Merge branch 'oplog' into decorators
AlekSi Sep 5, 2023
9c5bdd5
Make repl to work
AlekSi Sep 5, 2023
38b34d2
Add TODOs
AlekSi Sep 5, 2023
788fa5f
Update labels
AlekSi Sep 5, 2023
a2b2939
Improve test
AlekSi Sep 5, 2023
c965516
Lint
AlekSi Sep 5, 2023
396d386
Merge branch 'oplog' into decorators
AlekSi Sep 5, 2023
24a97d8
Merge branch 'main' into decorators
AlekSi Sep 6, 2023
fd865d4
Pass all options
AlekSi Sep 6, 2023
add67f0
Merge branch 'main' into decorators
AlekSi Sep 6, 2023
6749a40
Add `saslStart`
AlekSi Sep 6, 2023
09fede8
re-lint
AlekSi Sep 6, 2023
4ad6000
Merge branch 'main' into decorators
AlekSi Sep 6, 2023
8a85d16
Add missing methods
AlekSi Sep 6, 2023
a0b3b66
Merge branch 'decorators' into new-pg
AlekSi Sep 6, 2023
f52c8ef
Merge branch 'main' into new-pg
AlekSi Sep 7, 2023
37d431a
Use Ping method
AlekSi Sep 7, 2023
dcb1dcd
Implement ping
AlekSi Sep 7, 2023
89d4eaa
WIP
AlekSi Sep 7, 2023
98deddf
Merge branch 'main' into new-pg
AlekSi Sep 7, 2023
d06229e
Merge branch 'main' into new-pg
AlekSi Sep 7, 2023
88ba789
Remove `Clode`
AlekSi Sep 7, 2023
d808d41
Tweak
AlekSi Sep 7, 2023
6eb8442
Remove `Database.Close`, add `Database.Ping`
AlekSi Sep 7, 2023
f4c3cee
Relax toolchain
AlekSi Sep 7, 2023
0a76b0b
Merge branch 'ping-close' into new-pg
AlekSi Sep 7, 2023
879e8f5
Do not use Ping just yet
AlekSi Sep 7, 2023
bca9caa
Remove ping
AlekSi Sep 7, 2023
948d239
Update comments
AlekSi Sep 7, 2023
a232c4f
Remove conninfo reference
AlekSi Sep 7, 2023
2eedebd
Remove commented out code
AlekSi Sep 7, 2023
949135e
Merge branch 'ping-close' into new-pg
AlekSi Sep 7, 2023
78be87e
Unskip test
AlekSi Sep 8, 2023
8b11dd8
Merge branch 'ping-close' into new-pg
AlekSi Sep 8, 2023
91d5772
Merge branch 'main' into new-pg
AlekSi Sep 8, 2023
5d08d85
Merge branch 'main' into new-pg
AlekSi Sep 8, 2023
fea87fc
Start pool
AlekSi Sep 8, 2023
f4b9db8
Rework
AlekSi Sep 10, 2023
a2c9b56
Tweaks
AlekSi Sep 10, 2023
31809de
Tweak flags
AlekSi Sep 10, 2023
ea4d7db
Tweak flags
AlekSi Sep 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove commented out code
  • Loading branch information
AlekSi committed Sep 7, 2023
commit 2eedebd305208cc3b583d4ee7aba47f631a7d1b2
7 changes: 3 additions & 4 deletions internal/handlers/sqlite/msg_ping.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,9 @@ func (h *Handler) MsgPing(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg, er
return nil, lazyerrors.Error(err)
}

_ = db
// if err = db.Ping(ctx); err != nil {
// return nil, lazyerrors.Error(err)
// }
if _, err := db.ListCollections(ctx, nil); err != nil {
return nil, lazyerrors.Error(err)
}

var reply wire.OpMsg
must.NoError(reply.SetSections(wire.OpMsgSection{
Expand Down