Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getLog for SQLite #3279

Merged
merged 24 commits into from
Sep 4, 2023
Merged

Implement getLog for SQLite #3279

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
889af91
wip
rumyantseva Aug 29, 2023
ffd5e29
wip
rumyantseva Aug 29, 2023
f00dc3b
no handler version for SQLite
rumyantseva Aug 30, 2023
cb69450
wip
rumyantseva Aug 30, 2023
6b13139
wip
rumyantseva Aug 30, 2023
9e7c7a2
wip
rumyantseva Aug 30, 2023
2e08561
wip
rumyantseva Aug 30, 2023
2f87c9f
wip
rumyantseva Aug 30, 2023
dfadf3c
wip
rumyantseva Aug 30, 2023
ae36e38
wip
rumyantseva Aug 30, 2023
66cdd39
wip
rumyantseva Aug 31, 2023
37f85e8
Merge branch 'main' into issue-3261-get-log
rumyantseva Aug 31, 2023
12da633
wip
rumyantseva Aug 31, 2023
76b8d99
wip
rumyantseva Aug 31, 2023
75b5cdd
wip
rumyantseva Aug 31, 2023
e48a0bb
wip
rumyantseva Aug 31, 2023
cee30ac
use state
rumyantseva Sep 1, 2023
14b5853
print version
rumyantseva Sep 1, 2023
84f7e84
remove unnecessary version
rumyantseva Sep 1, 2023
badab62
cleanup version calculation
rumyantseva Sep 1, 2023
8200a08
merge conflict
rumyantseva Sep 1, 2023
3e27ca3
add test for version
rumyantseva Sep 1, 2023
9c4317d
fix tests
rumyantseva Sep 1, 2023
83a834b
wip
rumyantseva Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip
  • Loading branch information
@rumyantseva
rumyantseva committed Aug 31, 2023
commit 76b8d996fbc616fd6c969e2c5e2a5a0868651bf1
7 changes: 6 additions & 1 deletion internal/backends/sqlite/metadata/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,12 @@ func (r *Registry) Version(ctx context.Context) (string, error) {
return r.version, nil
}

row := r.p.GetFirst(ctx).QueryRowContext(context.Background(), "SELECT sqlite_version()")
db := r.p.GetFirst(ctx)
if db == nil {
return "", nil
}

row := db.QueryRowContext(context.Background(), "SELECT sqlite_version()")
chilagrow marked this conversation as resolved.
Show resolved Hide resolved
if err := row.Scan(&r.version); err != nil {
chilagrow marked this conversation as resolved.
Show resolved Hide resolved
return "", lazyerrors.Error(err)
}
Expand Down