Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement listDatabases for SQLite #3269

Merged
merged 15 commits into from
Sep 8, 2023
Merged

Implement listDatabases for SQLite #3269

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d44c37c
wip
rumyantseva Aug 29, 2023
1bae8e9
wip
rumyantseva Aug 29, 2023
b6f62db
wip
rumyantseva Aug 29, 2023
7c04e20
Merge branch 'main' into issue-3206-list-db
Aug 29, 2023
1227372
Check that dbstats are available
AlekSi Aug 29, 2023
59a1a56
merge conflict
rumyantseva Sep 1, 2023
dc39a81
implementaiton via dbstats
rumyantseva Sep 1, 2023
82aa04a
cleanup
rumyantseva Sep 1, 2023
6d180ca
wip
rumyantseva Sep 1, 2023
7cc5d6f
merge conflict
chilagrow Sep 7, 2023
a3b2cfe
handle error code
chilagrow Sep 7, 2023
0e64a14
move db close logic
chilagrow Sep 7, 2023
474e7f9
Merge branch 'main' into issue-3206-list-db
AlekSi Sep 7, 2023
58b19d7
remove close on DB
chilagrow Sep 8, 2023
1cf365e
Merge branch 'main' into issue-3206-list-db
AlekSi Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip
  • Loading branch information
@rumyantseva
rumyantseva committed Sep 1, 2023
commit 6d180ca929a8e52993222566ac2626cf4c8b1b8b
5 changes: 0 additions & 5 deletions internal/backends/sqlite/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,6 @@ func (b *backend) ListDatabases(ctx context.Context, params *backends.ListDataba
}

for i, dbName := range list {
d := b.r.DatabaseGetExisting(ctx, dbName)
if d == nil {
continue
}

db, err := b.Database(dbName)
if err != nil {
return nil, lazyerrors.Error(err)
Expand Down