Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and deprecate commonerrors.WriteErrors #3258

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Simplify and deprecate commonerrors.WriteErrors #3258

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5875df9
Update release checklist
AlekSi Aug 28, 2023
65412dd
Remove closed issue
AlekSi Aug 28, 2023
426b969
WIP
AlekSi Aug 28, 2023
ef4822e
Merge remote-tracking branch 'upstream/main' into write-errors
AlekSi Aug 28, 2023
ee9927d
WIP
AlekSi Aug 28, 2023
10f0458
Deprecate WriteErrors
AlekSi Aug 28, 2023
9457849
Update comments
AlekSi Aug 29, 2023
7012ad6
Merge branch 'main' into write-errors
AlekSi Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove closed issue
  • Loading branch information
@AlekSi
AlekSi committed Aug 28, 2023
commit 65412dd06245b02e4f76ff553ec9273bfe96199e
1 change: 0 additions & 1 deletion internal/handlers/common/aggregations/operators/accumulators/accumulators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ type Accumulator interface {

// NewAccumulator returns accumulator for provided value.
func NewAccumulator(stage, key string, value any) (Accumulator, error) {
// TODO https://github.com/FerretDB/FerretDB/issues/2689
accumulation, ok := value.(*types.Document)
if !ok || accumulation.Len() == 0 {
return nil, commonerrors.NewCommandErrorMsgWithArgument(
Expand Down