Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new PostgreSQL backend stub #3251

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Add new PostgreSQL backend stub #3251

merged 6 commits into from
Aug 25, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 25, 2023 •
edited
Loading

Description

For the future work.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 25, 2023
@AlekSi AlekSi self-assigned this Aug 25, 2023
@AlekSi AlekSi changed the title Add new pg backend stub Add new PostgreSQL backend stub Aug 25, 2023
@AlekSi AlekSi added this to the Next milestone Aug 25, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Aug 25, 2023
@AlekSi AlekSi marked this pull request as ready for review August 25, 2023 10:36
@AlekSi AlekSi requested a review from a team as a code owner August 25, 2023 10:36
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team and noisersup August 25, 2023 10:36
@AlekSi AlekSi enabled auto-merge (squash) August 25, 2023 10:37
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #3251 (824ef55) into main (13240bf) will decrease coverage by 0.17%.
The diff coverage is 18.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
- Coverage   75.40%   75.23%   -0.17%     
==========================================
  Files         397      400       +3     
  Lines       22327    22386      +59     
==========================================
+ Hits        16835    16842       +7     
- Misses       4518     4571      +53     
+ Partials      974      973       -1
Files Changed Coverage Δ
build/version/version.go 67.64% <ø> (ø)
internal/backends/postgresql/backend.go 0.00% <0.00%> (ø)
internal/backends/postgresql/collection.go 0.00% <0.00%> (ø)
internal/backends/postgresql/database.go 0.00% <0.00%> (ø)
internal/backends/sqlite/backend.go 77.41% <ø> (ø)
internal/handlers/registry/pg.go 100.00% <ø> (ø)
internal/handlers/registry/registry.go 50.00% <0.00%> (-5.56%) ⬇️
internal/handlers/sqlite/sqlite.go 58.97% <56.25%> (-7.70%) ⬇️
internal/handlers/registry/sqlite.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.65% <18.46%> (-0.22%) ⬇️
mongodb 5.25% <0.00%> (-0.02%) ⬇️
pg 64.69% <0.00%> (-0.22%) ⬇️
shard-1 56.81% <18.46%> (-0.13%) ⬇️
shard-2 56.19% <18.46%> (-0.29%) ⬇️
shard-3 54.87% <18.46%> (-0.18%) ⬇️
sqlite 47.01% <18.46%> (-0.11%) ⬇️
unit 24.50% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

noisersup
noisersup reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linters need to be addressed

internal/backends/postgresql/backend.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/sqlite.go Outdated Show resolved Hide resolved
@AlekSi AlekSi disabled auto-merge August 25, 2023 11:43
@AlekSi AlekSi merged commit 6601d82 into FerretDB:main Aug 25, 2023
@AlekSi AlekSi deleted the new-pg-stub branch August 25, 2023 11:43
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Add new PostgreSQL backend stub (FerretDB#3251)
e781985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @noisersup