Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that client metadata not being mutated #3194

Merged
merged 45 commits into from
Sep 28, 2023
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
de624a8
add support for not mutating client metadata
kropidlowsky Aug 9, 2023
9268714
fmt
kropidlowsky Aug 10, 2023
a714413
Merge branch 'main' into client_metadata_not_mutated
kropidlowsky Aug 10, 2023
7637037
rename helper function
kropidlowsky Aug 12, 2023
a87e3f7
fix test
kropidlowsky Aug 12, 2023
35eeed5
Merge branch 'main' into client_metadata_not_mutated
kropidlowsky Aug 12, 2023
6872ba8
Merge branch 'main' into client_metadata_not_mutated
kropidlowsky Aug 19, 2023
06bb537
replace `error` with `cmd error`
kropidlowsky Aug 20, 2023
91209ce
update `TestMutatingClientMetadata`
kropidlowsky Aug 20, 2023
3cd7d0c
add ErrClientMetadataCannotBeMutated
kropidlowsky Aug 20, 2023
6079657
stringer
kropidlowsky Aug 20, 2023
4e26661
align with linter
kropidlowsky Aug 20, 2023
65650df
fix misspelling in the name of integration test
kropidlowsky Aug 22, 2023
e88f511
fix func calls
noisersup Aug 25, 2023
1c58453
Merge branch 'main' into client_metadata_not_mutated
AlekSi Aug 25, 2023
823c0cf
Merge branch 'main' into client_metadata_not_mutated
kropidlowsky Aug 29, 2023
21df0fb
Merge branch 'FerretDB:main' into client_metadata_not_mutated
kropidlowsky Sep 5, 2023
0579c1e
add client metadata to conninfo
kropidlowsky Sep 7, 2023
3309323
Merge branch 'main' into client_metadata_not_mutated
AlekSi Sep 8, 2023
ecc9633
WIP
kropidlowsky Sep 10, 2023
9bb1963
move CheckClientMetadata to metadata.go
kropidlowsky Sep 13, 2023
828610b
TestMutatingClientMetadata - cut altMessage
kropidlowsky Sep 13, 2023
2e4b629
unit test - TestCheckClientMetadata
kropidlowsky Sep 13, 2023
74a7487
move clientMetadataPresence under the same mutex hat
kropidlowsky Sep 17, 2023
3ddfeab
ClientMetadataPresence()
kropidlowsky Sep 17, 2023
63e0463
add closing connInfo in TestCheckClientMetadata
kropidlowsky Sep 17, 2023
fc7cbe7
add CheckClientMetadata err handling in CmdQuery
kropidlowsky Sep 17, 2023
44138f4
fix comment
kropidlowsky Sep 17, 2023
ff586eb
lint
kropidlowsky Sep 17, 2023
ca7ea70
CmdQuery - move CheckClientMetadata under isMaster
kropidlowsky Sep 17, 2023
4ae103c
Merge branch 'main' into client_metadata_not_mutated
kropidlowsky Sep 17, 2023
82c64ac
add connInfo.Close to CheckClientMetadata
kropidlowsky Sep 18, 2023
90379c6
Merge branch 'main' into client_metadata_not_mutated
kropidlowsky Sep 19, 2023
03db7c1
ClientMetadataPresence - replace Lock with Rlock
kropidlowsky Sep 19, 2023
99e5948
allign to simplified conninfo
kropidlowsky Sep 19, 2023
75f3875
Update internal/clientconn/conninfo/conn_info.go
kropidlowsky Sep 20, 2023
436ba21
wip
kropidlowsky Sep 21, 2023
0348c59
Merge branch 'main' into client_metadata_not_mutated
kropidlowsky Sep 24, 2023
5c69530
Merge branch 'main' into pr/kropidlowsky/3194
AlekSi Sep 27, 2023
be944e7
Move metadata check to the right place
AlekSi Sep 27, 2023
e54f6cf
Reformat and simplify
AlekSi Sep 27, 2023
1445869
Lint
AlekSi Sep 27, 2023
75c4e75
Simplify
AlekSi Sep 27, 2023
7e05687
Merge branch 'main' into client_metadata_not_mutated
mergify[bot] Sep 28, 2023
4e77bb8
Merge branch 'main' into client_metadata_not_mutated
mergify[bot] Sep 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
kropidlowsky committed Aug 10, 2023
commit 926871433359d15c4a6e5603b9d16d8fcad6e737
1 change: 0 additions & 1 deletion integration/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,6 @@ func TestMutatingClientMetadata(t *testing.T) {
var actualRes bson.D
err := res.Decode(&actualRes)
require.EqualError(t, err, "The client metadata document may only be sent in the first hello")

})
}
}