Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support recursive operator calls for $sum aggregation accumulator #3116

Merged
merged 18 commits into from
Jul 31, 2023
Merged

Support recursive operator calls for $sum aggregation accumulator #3116

merged 18 commits into from
Jul 31, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jul 26, 2023 •
edited
Loading

Description

Closes #2694.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Jul 26, 2023
@noisersup noisersup added not ready Issues that are not ready to be worked on; PRs that should skip CI code/chore Code maintenance improvements labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #3116 (79ba6eb) into main (48dad10) will increase coverage by 0.02%.
The diff coverage is 75.86%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3116      +/-   ##
==========================================
+ Coverage   75.94%   75.96%   +0.02%     
==========================================
  Files         392      392              
  Lines       21726    21750      +24     
==========================================
+ Hits        16499    16523      +24     
- Misses       4274     4276       +2     
+ Partials      953      951       -2
Files Changed Coverage Δ
...ernal/handlers/common/aggregations/stages/group.go 84.67% <66.66%> (+0.40%) ⬆️
.../common/aggregations/operators/accumulators/sum.go 84.61% <76.92%> (-4.28%) ⬇️

... and 9 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.51% <75.86%> (+0.01%) ⬆️
mongodb 5.42% <0.00%> (-0.01%) ⬇️
pg 65.60% <75.86%> (-0.02%) ⬇️
shard-1 55.49% <6.89%> (+0.01%) ⬆️
shard-2 53.66% <75.86%> (+0.16%) ⬆️
shard-3 58.68% <6.89%> (-0.11%) ⬇️
sqlite 46.15% <0.00%> (-0.01%) ⬇️
unit 24.01% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup changed the title Support recursive operator calls for $sum aggregation operator Support recursive operator calls for $sum aggregation accumulator Jul 26, 2023
@noisersup noisersup removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 27, 2023
@noisersup noisersup marked this pull request as ready for review July 28, 2023 00:05
@noisersup noisersup requested a review from a team as a code owner July 28, 2023 00:05
@noisersup noisersup requested review from AlekSi, rumyantseva, a team and chilagrow July 28, 2023 00:05
chilagrow
chilagrow reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny comment 🤗

internal/handlers/common/aggregations/operators/accumulators/sum.go Show resolved Hide resolved
@noisersup noisersup requested a review from chilagrow July 28, 2023 11:05
chilagrow
chilagrow approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

internal/handlers/common/aggregations/operators/accumulators/sum.go Show resolved Hide resolved
rumyantseva
rumyantseva approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests and implementation look good to me!

@noisersup noisersup enabled auto-merge (squash) July 31, 2023 09:09
@noisersup noisersup merged commit 66304b7 into FerretDB:main Jul 31, 2023
@noisersup noisersup deleted the aggregation-recursive-sum-2964 branch July 31, 2023 09:10
@AlekSi AlekSi added this to the v1.7.0 milestone Aug 14, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@noisersup @yonarw
Support recursive operator calls for $sum aggregation accumulator (F…
ae24839 
…erretDB#3116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Support recursive aggregation operators
4 participants
@noisersup @rumyantseva @chilagrow @AlekSi