-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support _id
aggregation operators for $group
stage
#3096
Support _id
aggregation operators for $group
stage
#3096
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3096 +/- ##
==========================================
- Coverage 76.60% 74.41% -2.19%
==========================================
Files 390 390
Lines 21330 21419 +89
==========================================
- Hits 16339 15940 -399
- Misses 4073 4543 +470
- Partials 918 936 +18
... and 27 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
34bdbbd
to
5d30c49
Compare
@noisersup the linter fails! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments about test coverage. Also there are failing tests on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check the test coverage again please 🙏 . There are still quite a bit that are not covered.
The error handing code seems quite duplicated, do you think we can merge them as stage input error handling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! 🚀
Description
Closes #2694.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.