Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed issue link and clean up integration test provider setup #3052

Merged
merged 7 commits into from
Jul 17, 2023
Merged

Remove fixed issue link and clean up integration test provider setup #3052

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f176180
add skipped test
chilagrow Jul 14, 2023
517cbe1
replace long provider list with remove
chilagrow Jul 14, 2023
92bea20
use object comparison
chilagrow Jul 14, 2023
22ad9a0
AllProviders do not skip any provider
chilagrow Jul 14, 2023
224142f
one more exception
chilagrow Jul 14, 2023
50f885d
add todo for failing projection test
chilagrow Jul 14, 2023
d465cdc
Merge branch 'main' into issue-2184-analysis
AlekSi Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replace long provider list with remove
  • Loading branch information
@chilagrow
chilagrow committed Jul 14, 2023
commit 517cbe15b11188b1c660a913ce7aec191c2897f4
46 changes: 3 additions & 43 deletions integration/aggregate_documents_compat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,55 +396,15 @@ func TestAggregateCompatCount(t *testing.T) {
func TestAggregateCompatGroupDeterministicCollections(t *testing.T) {
t.Parallel()

// Scalars collection is not included because aggregation groups
// numbers of different types for $group, and this causes output
// _id to be different number type between compat and target.
// https://github.com/FerretDB/FerretDB/issues/2184
//
// Composites, ArrayStrings, ArrayInt32s and ArrayAndDocuments are not included
// Composites, ArrayStrings, ArrayInt32s, ArrayAndDocuments and Mixed are not included
// because the order in compat and target can be not deterministic.
// Aggregation assigns BSON array to output _id, and an array with
// descending sort use the greatest element for comparison causing
// multiple documents with the same greatest element the same order,
// so compat and target results in different order.
// https://github.com/FerretDB/FerretDB/issues/2185

providers := []shareddata.Provider{
// shareddata.Scalars,

shareddata.Doubles,
shareddata.OverflowVergeDoubles,
shareddata.SmallDoubles,
shareddata.Strings,
shareddata.Binaries,
shareddata.ObjectIDs,
shareddata.Bools,
shareddata.DateTimes,
shareddata.Nulls,
shareddata.Regexes,
shareddata.Int32s,
shareddata.Timestamps,
shareddata.Int64s,
shareddata.Unsets,
shareddata.ObjectIDKeys,

// shareddata.Composites,
shareddata.PostgresEdgeCases,

shareddata.DocumentsDoubles,
shareddata.DocumentsStrings,
shareddata.DocumentsDocuments,

// shareddata.ArrayStrings,
shareddata.ArrayDoubles,
// shareddata.ArrayInt32s,
shareddata.ArrayRegexes,
shareddata.ArrayDocuments,

// shareddata.Mixed,
// shareddata.ArrayAndDocuments,
}

providers := shareddata.AllProviders().Remove("Composites", "ArrayStrings", "ArrayInt32s", "ArrayAndDocuments", "Mixed")
testCases := map[string]aggregateStagesCompatTestCase{
"DistinctValue": {
pipeline: bson.A{
Expand All @@ -471,7 +431,7 @@ func TestAggregateCompatGroupDeterministicCollections(t *testing.T) {
// because _id of group can be an array
bson.D{{"$sort", bson.D{{"unique", 1}}}},
},
skip: "https://github.com/FerretDB/FerretDB/issues/2184",
skip: "https://github.com/FerretDB/FerretDB/issues/2185",
},
"CountValue": {
pipeline: bson.A{
Expand Down