Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed issue link and clean up integration test provider setup #3052

Merged
merged 7 commits into from
Jul 17, 2023
Merged

Remove fixed issue link and clean up integration test provider setup #3052

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f176180
add skipped test
chilagrow Jul 14, 2023
517cbe1
replace long provider list with remove
chilagrow Jul 14, 2023
92bea20
use object comparison
chilagrow Jul 14, 2023
22ad9a0
AllProviders do not skip any provider
chilagrow Jul 14, 2023
224142f
one more exception
chilagrow Jul 14, 2023
50f885d
add todo for failing projection test
chilagrow Jul 14, 2023
d465cdc
Merge branch 'main' into issue-2184-analysis
AlekSi Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
one more exception
  • Loading branch information
@chilagrow
chilagrow committed Jul 14, 2023
commit 224142f94245b626518dc1bdc699a8e3b0482e08
4 changes: 2 additions & 2 deletions integration/aggregate_documents_compat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,12 +632,12 @@ func TestAggregateCompatGroupExpressionDottedFields(t *testing.T) {

// TODO Use all providers after fixing $sort problem: https://github.com/FerretDB/FerretDB/issues/2276.
//
// Currently, providers Composites, DocumentsDeeplyNested and Mixed
// Currently, providers Composites, DocumentsDeeplyNested, ArrayAndDocuments and Mixed
// cannot be used due to sorting difference.
// FerretDB always sorts empty array is less than null.
// In compat, for `.sort()` an empty array is less than null.
// In compat, for aggregation `$sort` null is less than an empty array.
providers := shareddata.AllProviders().Remove(shareddata.Mixed, shareddata.Composites, shareddata.DocumentsDeeplyNested)
providers := shareddata.AllProviders().Remove(shareddata.Mixed, shareddata.Composites, shareddata.DocumentsDeeplyNested, shareddata.ArrayAndDocuments)

testCases := map[string]aggregateStagesCompatTestCase{
"NestedInDocument": {
Expand Down