Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SQLite directory to URI #2922

Merged
merged 35 commits into from
Jul 3, 2023
Merged

Convert SQLite directory to URI #2922

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
f43eca4
WIP
Jun 27, 2023
16f2659
Merge branch 'main' into issue-2753-sqlite-uri
Jun 29, 2023
776fcd9
WIP
Jun 29, 2023
904458e
WIP
Jun 29, 2023
61da23d
WIP
Jun 29, 2023
f7e81ef
WIP
Jun 29, 2023
6e305b8
WIP
Jun 29, 2023
beb0d2a
WIP
Jun 29, 2023
b1e1d72
WIP
Jun 29, 2023
abc93fd
WIP
Jun 29, 2023
8418437
WIP
Jun 29, 2023
2d2961a
WIP
Jun 29, 2023
d23d631
Merge branch 'main' into issue-2753-sqlite-uri
Jun 29, 2023
97d1604
WIP
Jun 29, 2023
0ba85cc
WIP
Jun 29, 2023
b4d906f
WIP
Jun 29, 2023
98b3319
WIP
Jun 29, 2023
85a8acd
WIP
Jun 29, 2023
622256d
Update internal/backends/sqlite/backend.go
Jun 30, 2023
184ca66
Update internal/backends/sqlite/backend.go
Jun 30, 2023
5afef71
Update main.go
Jun 30, 2023
7c222bc
WIP
Jun 30, 2023
b87081a
Merge branch 'issue-2753-sqlite-uri' of https://github.com/w84thesun/…
Jun 30, 2023
f526608
Merge branch 'main' into issue-2753-sqlite-uri
Jun 30, 2023
047985a
Merge branch 'main' into issue-2753-sqlite-uri
AlekSi Jun 30, 2023
c97fff7
Merge branch 'main' into issue-2753-sqlite-uri
Jun 30, 2023
ce2ac02
WIP
Jun 30, 2023
9d58674
WIP
Jun 30, 2023
63bec56
Merge branch 'main' into issue-2753-sqlite-uri
Jun 30, 2023
4e7b444
WIP
Jun 30, 2023
06fc4e9
Merge remote-tracking branch 'origin/issue-2753-sqlite-uri' into issu…
Jun 30, 2023
48e3497
Make it work
AlekSi Jul 3, 2023
b11fde7
Small tweaks
AlekSi Jul 3, 2023
4dc278b
Move code
AlekSi Jul 3, 2023
8499c8f
Remove old line
AlekSi Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update internal/backends/sqlite/backend.go 
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
  • Loading branch information
@chilagrow
Dmitry and chilagrow authored Jun 30, 2023
commit 184ca66c5d68a5430327c09cbdf81d23456054f8
2 changes: 1 addition & 1 deletion internal/backends/sqlite/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func validateURI(value string) (*url.URL, error) {
}

if !strings.HasSuffix(dir, "/") {
return nil, lazyerrors.Errorf("backend URI should be a directory: %q", value)
return nil, lazyerrors.Errorf("backend URI should be a directory ending with '/': %q", value)
}

fi, err := os.Stat(dir)
Expand Down