-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate database and collection names for SQLite handler #2868
Merged
Merged
Changes from 1 commit
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
6e3df55
wip
noisersup 8a2af00
wip
noisersup ae491af
wip
noisersup 3f84105
basic
noisersup a5ca6cb
remove CollectionToTable from struct
noisersup 88182fb
Replace with collectionGet
noisersup 2009ea8
it works???
noisersup 07738c7
test case
noisersup 004aa8e
wip
noisersup 1178e65
prefix validation
noisersup 019ceb7
Merge branch 'main' into validate-db-coll-2749
noisersup 8c3714d
tweak
noisersup 1012a42
wip
noisersup 7230c38
fix dot for postgres
noisersup 176cb05
fix dot for sqlite
noisersup f184458
Merge remote-tracking branch 'upstream/main' into validate-db-coll-2749
noisersup 2fbbd64
Update sqlite comment
noisersup dac0fa9
wip
noisersup f97a473
add sqlite validation
noisersup c179a50
add comment + lint
noisersup 4bfe05b
fmt
noisersup 825b11b
Merge branch 'main' into validate-db-coll-2749
noisersup 4d98281
wip
noisersup 0332333
wip
noisersup 257e866
make all table names lowercase
noisersup 7505d9a
proper error handling
noisersup f05bf62
lot of changes
noisersup 15d7c77
Merge remote-tracking branch 'upstream/main' into validate-db-coll-2749
noisersup 1ef2680
wip
noisersup a16bb20
fix
noisersup 12a80e4
wip
noisersup 2db636d
wip
noisersup ef77cfe
wip
noisersup 9463201
Merge branch 'main' into validate-db-coll-2749
494dcd7
pair programming
noisersup 53518ae
improve prefix check
noisersup 3b95fe1
wip
noisersup af07a45
Merge branch 'fix-after-bump' into validate-db-coll-2749
noisersup b3d66ab
Remove test
noisersup 10dcbaa
Merge branch 'fix-after-bump' into validate-db-coll-2749
noisersup 1c2f423
apply review comments
noisersup 8f5667c
Merge branch 'main' into validate-db-coll-2749
c266454
Merge branch 'main' into validate-db-coll-2749
AlekSi c5fc06d
Update issue comment
AlekSi 50694df
Simplify
AlekSi a8bb524
rename CollectionGet
noisersup c81bc84
remove comment
noisersup 877d7d6
Merge branch 'main' into validate-db-coll-2749
cb80f54
wip
noisersup a3b9649
wip
noisersup 7c075bc
wip
noisersup 43c36ae
wip
noisersup 22ff58d
lint
noisersup 0d617a5
Merge branch 'main' into validate-db-coll-2749
6780ab3
remove unused errorcode
noisersup 50397c1
remove empty collection error from update
noisersup af88550
Merge remote-tracking branch 'upstream/main' into validate-db-coll-2749
noisersup 1b1a1f4
cleanup
noisersup 122b3fe
Merge branch 'main' into validate-db-coll-2749
AlekSi 6922636
Merge branch 'main' into pr/noisersup/2868-1
AlekSi 88c3c77
Merge branch 'main' into validate-db-coll-2749
AlekSi 5e519bd
Tweak comment
AlekSi 81eb51d
Merge branch 'main' into pr/noisersup/2868
AlekSi 75706fd
Update comments
AlekSi 8346e0c
Merge branch 'main' into pr/noisersup/2868
AlekSi e4e77bf
Add linter configuration
AlekSi eaf50a9
Improve tests
AlekSi d95cca4
Tweaks
AlekSi 5fef6b7
Do not import `commonerrors` in tests
AlekSi 0b96a31
Merge branch 'commonerrors' into pr/noisersup/2868
AlekSi c875dd1
More work
AlekSi 14e2bff
Add comment
AlekSi 67f909b
Create unique index
AlekSi a500b14
Merge branch 'main' into validate-db-coll-2749
AlekSi b6d2961
Make SQLite URL configurable
AlekSi 6a35453
Add validation
AlekSi a18b8f2
Merge branch 'main' into pr/noisersup/2868
AlekSi e070733
Merge branch 'main' into validate-db-coll-2749
AlekSi c5cc1d5
Update comments
AlekSi be93b2d
Tweak validation
AlekSi fe79866
Fix number
AlekSi 1344019
Merge branch 'main' into validate-db-coll-2749
AlekSi 1c72efc
Update comment
AlekSi cc083fa
Update comments
AlekSi 296973f
Tiny tweak
AlekSi 20f8200
Fix tests
AlekSi 0cc1df7
Merge branch 'main' into validate-db-coll-2749
AlekSi c39f316
Lint
AlekSi e266e35
Add explicit panic
AlekSi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tweak
- Loading branch information
commit 8c3714d368fe6972374b696156e42b38d8d21a7b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's not a lazy error but some other error? Maybe the easiest way is to run some test that already queries/modifies a non-existent collection to see how this should reflect it.