Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify what's left in handling OP_MSG checksum #2677

Merged
merged 4 commits into from
May 24, 2023
Merged

Clarify what's left in handling OP_MSG checksum #2677

merged 4 commits into from
May 24, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 22, 2023 •
edited
Loading

Description

Closes #2691.

I created a new issue #2690 to address the current challenges around checksum calculation.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this May 22, 2023
@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #2677 (1da7fd6) into main (72503d4) will increase coverage by 0.00%.
The diff coverage is 56.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2677   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files         432      432           
  Lines       22230    22236    +6     
=======================================
+ Hits        13946    13950    +4     
- Misses       7356     7358    +2     
  Partials      928      928
Impacted Files Coverage Δ
internal/wire/op_msg.go 57.26% <50.00%> (-0.14%) ⬇️
internal/wire/msg_body.go 47.05% <57.14%> (+1.05%) ⬆️
Flag Coverage Δ
integration 56.05% <16.00%> (-0.01%) ⬇️
mongodb 5.05% <0.00%> (-0.01%) ⬇️
pg 55.97% <16.00%> (-0.01%) ⬇️
unit 25.05% <56.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva changed the title Write CRC32 Clarify what's left in handling OP_MSG checksum May 23, 2023
@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 23, 2023
@rumyantseva rumyantseva requested review from a team, w84thesun, chilagrow and noisersup May 23, 2023 15:28
@rumyantseva rumyantseva marked this pull request as ready for review May 23, 2023 15:28
@rumyantseva rumyantseva requested a review from a team as a code owner May 23, 2023 15:28
chilagrow
chilagrow approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the detailed issue

w84thesun
w84thesun approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@w84thesun w84thesun enabled auto-merge (squash) May 24, 2023 09:48
noisersup
noisersup approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@w84thesun w84thesun merged commit fef76e1 into FerretDB:main May 24, 2023
@AlekSi AlekSi added this to the v1.3.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Clarify what's left in handling OP_MSG checksum
5 participants
@rumyantseva @w84thesun @chilagrow @noisersup @AlekSi