fix race

FerretDB · chilagrow · Mar 31, 2023 · Mar 29, 2023 · Mar 29, 2023 · Mar 29, 2023
commit 3c318c6745b68b512ce2b0d939a4349c6755f752
@@ -323,18 +323,20 @@ func TestDropIndexesStress(t *testing.T) {
 
 			<-start
 
-			err = pool.InTransaction(ctx, func(tx pgx.Tx) error {
+			// do not use `err`, to avoid data race
+			tErr := pool.InTransaction(ctx, func(tx pgx.Tx) error {
 				idx := Index{
 					Name: indexName,
 					Key:  indexKeys,
 				}
 
-				_, err = DropIndex(ctx, tx, databaseName, collectionName, &idx)
-				return err
+				// do not use `err`, to avoid data race
+				_, dropErr := DropIndex(ctx, tx, databaseName, collectionName, &idx)
+				return dropErr
 			})
 			// if the index could not be dropped, the error is checked
-			if err != nil {
-				require.Error(t, err, ErrIndexNotExist)
+			if tErr != nil {
+				require.Error(t, tErr, ErrIndexNotExist)
 			}
 		}()
 	}