add batchsize support for Handler

FerretDB · Feb 27, 2024 · 1bf9901 · 1bf9901
1 parent b6fd73b
commit 1bf9901
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 5 deletions.
diff --git a/cmd/ferretdb/main.go b/cmd/ferretdb/main.go
@@ -101,6 +101,7 @@ var cli struct {
 		} `embed:"" prefix:"capped-cleanup-"`
 
 		EnableNewAuth bool `default:"false" help:"Experimental: enable new authentication."`
+		BatchSize     int  `default:"100" help:"number of maximum size of query parameters"`
 
 		Telemetry struct {
 			URL            string        `default:"https://beacon.ferretdb.com/" help:"Telemetry: reporting URL."`
@@ -412,6 +413,7 @@ func run() {
 			CappedCleanupInterval:   cli.Test.CappedCleanup.Interval,
 			CappedCleanupPercentage: cli.Test.CappedCleanup.Percentage,
 			EnableNewAuth:           cli.Test.EnableNewAuth,
+			BatchSize:               cli.Test.BatchSize,
 		},
 	})
 	if err != nil {

diff --git a/internal/handler/handler.go b/internal/handler/handler.go
@@ -81,6 +81,7 @@ type NewOpts struct {
 	CappedCleanupInterval   time.Duration
 	CappedCleanupPercentage uint8
 	EnableNewAuth           bool
+	BatchSize               int
 }
 
 // New returns a new handler.

diff --git a/internal/handler/msg_insert.go b/internal/handler/msg_insert.go
@@ -85,13 +85,11 @@ func (h *Handler) MsgInsert(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg,
 
 	var done bool
 	for !done {
-		// TODO https://github.com/FerretDB/FerretDB/issues/3708
-		const batchSize = 1000
 
-		docs := make([]*types.Document, 0, batchSize)
-		docsIndexes := make([]int, 0, batchSize)
+		docs := make([]*types.Document, 0, h.BatchSize)
+		docsIndexes := make([]int, 0, h.BatchSize)
 
-		for j := 0; j < batchSize; j++ {
+		for j := 0; j < h.BatchSize; j++ {
 			var i int
 			var d any
 

diff --git a/internal/handler/registry/hana.go b/internal/handler/registry/hana.go
@@ -48,6 +48,7 @@ func init() {
 			CappedCleanupPercentage: opts.CappedCleanupPercentage,
 			CappedCleanupInterval:   opts.CappedCleanupInterval,
 			EnableNewAuth:           opts.EnableNewAuth,
+			BatchSize: opts.BatchSize
 		}
 
 		h, err := handler.New(handlerOpts)

diff --git a/internal/handler/registry/mysql.go b/internal/handler/registry/mysql.go
@@ -45,6 +45,7 @@ func init() {
 			CappedCleanupPercentage: opts.CappedCleanupPercentage,
 			CappedCleanupInterval:   opts.CappedCleanupInterval,
 			EnableNewAuth:           opts.EnableNewAuth,
+			BatchSize:               opts.BatchSize,
 		}
 
 		h, err := handler.New(handlerOpts)

diff --git a/internal/handler/registry/postgresql.go b/internal/handler/registry/postgresql.go
@@ -47,6 +47,7 @@ func init() {
 			CappedCleanupPercentage: opts.CappedCleanupPercentage,
 			CappedCleanupInterval:   opts.CappedCleanupInterval,
 			EnableNewAuth:           opts.EnableNewAuth,
+			BatchSize:               opts.BatchSize,
 		}
 
 		h, err := handler.New(handlerOpts)

diff --git a/internal/handler/registry/registry.go b/internal/handler/registry/registry.go
@@ -71,6 +71,7 @@ type TestOpts struct {
 	CappedCleanupInterval   time.Duration
 	CappedCleanupPercentage uint8
 	EnableNewAuth           bool
+	BatchSize               int
 	_                       struct{} // prevent unkeyed literals
 }
 

diff --git a/internal/handler/registry/sqlite.go b/internal/handler/registry/sqlite.go
@@ -47,6 +47,7 @@ func init() {
 			CappedCleanupPercentage: opts.CappedCleanupPercentage,
 			CappedCleanupInterval:   opts.CappedCleanupInterval,
 			EnableNewAuth:           opts.EnableNewAuth,
+			BatchSize:               opts.BatchSize,
 		}
 
 		h, err := handler.New(handlerOpts)