-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test #86 Cannot read Optional
s written with StdTypeResolverBuilder
#335
Conversation
@JooHyukKim Ok, this might be the way to do it, but we should actually change base (de)serializers from I also wonder if JSON serialization should (or should not) be changed for 3.0.
instead of what 2.x uses and expects:
Obviously such change cannot be done for 2.x, but could be done for 3.x. First things first however: this fix should be applied to |
Yeah this makes sense. Let's work through
What benefit are we expecting out of the described serialization form? |
Optional
s written with StdTypeResolverBuilder
Optional
s written with StdTypeResolverBuilder
@cowtowncoder Filed fix PR in databind module FasterXML/jackson-databind#4838 the PR contains how to test integrated etc... |
There may be multiple issues but the problem with
But I must admit that the interaction gets pretty complicated and fundamentally it might be that it is not possibly to only add new level for polymorphic case.
and
but it 'd have been simpler, in the end if those instead were serialized as
and
because then we wouldn't need convert But it may be bit late to change this even for 3.0. And there hasn't been too many reports for problems (there are some, wrt nested So let's focus on immediate issue and forget about what I was proposing for now. :) |
Closing due to reasons I mentioned in comment |
Optional
s written withStdTypeResolverBuilder
, from[jackson-modules-java8#86]
jackson-databind#4838