-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images to the Send-an-invoice help article #49667
Conversation
Adding screenshots to the Send Invoice section of the help article based on this GH - Expensify/Expensify#407250
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://42c7ee1a.helpdot.pages.dev ⚡️ |
Adding images to the Pay-an-invoice help article https://help.expensify.com/articles/new-expensify/expenses-&-payments/Pay-an-invoice
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Updated the image link as I entered it wrong
Updated the image link because I did it wrong the first time.
Made some changes which triggered a new check. But there's no new preview of the changes like there was with the old check. @MarioExpensify is there a way I can see a preview of the changes to make sure they are good? |
@Christinadobrzyn let me check and circle back to you |
Hi @Christinadobrzyn, it seems the process does update the preview, the link for the preview remains the same and you can check it here: https://1175050d.helpdot.pages.dev/ |
The ){:width=”100%”} was showing for each image in the preview - not what we want. So I made a change
There was another image that was better for this so I replaced the others with it.
Thanks @MarioExpensify! I reviewed both articles and needed to make a change to both so I just did that. If you can review again that'd be great! TY! |
I'm not sure why, but it seems the latest changes have been deployed to a different temporary URL: https://42c7ee1a.helpdot.pages.dev/ It looks good, approving and merging! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.0.41-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀
|
Adding screenshots to the Send Invoice section of the help article based on this GH - https://github.com/Expensify/Expensify/issues/407250
Details
Tracking GH- https://github.com/Expensify/Expensify/issues/407250
Fixed Issues
Adding screenshots to the Send an Invoice help article
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.