Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route #50051

Closed
6 tasks done
IuliiaHerets opened this issue Oct 2, 2024 · 15 comments
Closed
6 tasks done

[HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route #50051

IuliiaHerets opened this issue Oct 2, 2024 · 15 comments
Assignees
@abekkala @grgia
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 2, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense.
  3. Go to Distance.
  4. Enter waypoints > Next.
  5. Click Just track it.

Expected Result:

Distance and Rate will show the correct distance and rate when tracking via Just track it route.

Actual Result:

Distance and Rate show “Pending” when tracking via Just track it route.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6622008_1727865496284.track.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abekkala
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 2, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 2, 2024

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 2, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 2, 2024
@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot mentioned this issue Oct 2, 2024
Closed
56 tasks
@madmax330
Copy link
Contributor

cc @neil-marcellini can you take a look? Since you're more familiar with distance requests

@Shahidullah-Muffakir
Copy link
Contributor

Regression from #49007

@melvin-bot melvin-bot bot mentioned this issue Oct 2, 2024
Closed
@jasperhuangg
Copy link
Contributor

This is under a beta so there's no need to block deploy on this.

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 2, 2024
@madmax330
Copy link
Contributor

@grgia assigning you then since this is something that you're working on: #48787

@madmax330 madmax330 assigned grgia and unassigned madmax330 Oct 2, 2024
@grgia grgia mentioned this issue Oct 3, 2024
Merged
52 tasks
@melvin-bot melvin-bot bot added Overdue Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Oct 4, 2024
@melvin-bot melvin-bot bot changed the title Track distance - Distance and Rate show “Pending” when tracking via Just track it route [HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route Oct 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-11. 🎊

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 4, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@grgia] The PR that introduced the bug has been identified. Link to the PR:
  • [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@grgia] Determine if we should create a regression test for this bug.
  • [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@abekkala
Copy link
Contributor

abekkala commented Oct 7, 2024

PAYMENT SUMMARY FOR OCT 11

  • Fix: Internal @grgia
  • PR Review: @fedirjh [$250, if no regressions] payment via NewDot

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 7, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route Oct 7, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-14. 🎊

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 7, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@grgia] The PR that introduced the bug has been identified. Link to the PR:
  • [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@grgia] Determine if we should create a regression test for this bug.
  • [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@abekkala
Copy link
Contributor

abekkala commented Oct 8, 2024

The PR showed Deployed to Production on Oct 4 - that would make payment on Oct 11, not the 14th
Screenshot 2024-10-08 at 10 53 37 AM

@abekkala abekkala changed the title [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route [HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route Oct 8, 2024
@abekkala
Copy link
Contributor

posting summary once more before closing:

PAYMENT SUMMARY FOR OCT 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abekkala abekkala

@grgia grgia

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@madmax330 @abekkala @jasperhuangg @grgia @IuliiaHerets @Shahidullah-Muffakir