Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-10-09] Live MD - Composer does not scroll down after pasting content with inline image preview #49983

Closed
3 of 6 tasks
IuliiaHerets opened this issue Oct 1, 2024 · 12 comments
Closed
3 of 6 tasks

[HOLD for payment 2024-10-09] Live MD - Composer does not scroll down after pasting content with inline image preview #49983

IuliiaHerets opened this issue Oct 1, 2024 · 12 comments
Assignees
@mjasikowski @joekaufmanexpensify
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 1, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #49250
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM.
  3. Paste the following content.

test demo imagetest 😊

test demo imagetest 😊

Expected Result:

The composer will scroll down to the end after pasting the content.

Actual Result:

The composer does not scroll down to the end after pasting the content with inline image preview.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6620908_1727772620320.d.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 1, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to Live Markdown

@github-actions github-actions bot mentioned this issue Oct 1, 2024
Closed
49 tasks
@mjasikowski
Copy link
Contributor

Checking...

@mjasikowski
Copy link
Contributor

@Skalakid are you able to fix or revert this quickly?

@hungvu193
Copy link
Contributor

@mjasikowski I can create a revert if @Skalakid is AFK. There's another DB that related to recent liver markdown version too.

@joekaufmanexpensify
Copy link
Contributor

What is the bug? You're able to scroll in the video attached in OP?

@jasperhuangg

This comment was marked as resolved.

Sign in to view
@melvin-bot melvin-bot bot mentioned this issue Oct 1, 2024
Closed
6 tasks
@jasperhuangg jasperhuangg mentioned this issue Oct 1, 2024
Merged
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 1, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 2, 2024
@melvin-bot melvin-bot bot changed the title Live MD - Composer does not scroll down after pasting content with inline image preview [HOLD for payment 2024-10-09] Live MD - Composer does not scroll down after pasting content with inline image preview Oct 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 2, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.42-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-09. 🎊

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 2, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mjasikowski] The PR that introduced the bug has been identified. Link to the PR:
  • [@mjasikowski] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mjasikowski] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@mjasikowski] Determine if we should create a regression test for this bug.
  • [@mjasikowski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjasikowski mjasikowski

@joekaufmanexpensify joekaufmanexpensify

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mjasikowski @hungvu193 @jasperhuangg @joekaufmanexpensify @IuliiaHerets