Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
EvilSupahFly authored Dec 2, 2024
1 parent 55e5ebf commit 178aeca
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,17 @@ The initial Flatpak version was sourced from Amulet 0.10.34. With the update to

Currently the flatpak release suffers from ~~three~~ ~~two~~ one minor issue:
- flickering UI, which plagues upstream Amulet (Linux users only - see [here](https://github.com/Amulet-Team/Amulet-Map-Editor/issues))
~~- missing water and lava textures, which is unique to the flatpak version [issue #7](https://github.com/EvilSupahFly/Amulet-Flatpak/issues/7) and still being investigated.~~
- ~~Trying to run on Wayland, unless you have installed Xwayland, is mostly pointless because of some twenty-year-old code in wxPython - expect the error "Unable to access the X Display, is $DISPLAY set properly?"~~* (with update to v0.10.37 this is [now fixed](https://github.com/Amulet-Team/Amulet-Map-Editor/blob/128de1caec6cc7da035b8336cd804d33aa3d5adc/amulet_map_editor/__main__.py#L48).)
- ~~missing water and lava textures, which is unique to the flatpak version [issue #7](https://github.com/EvilSupahFly/Amulet-Flatpak/issues/7) and still being investigated.~~
- ~~Trying to run on Wayland, unless you have installed Xwayland, is mostly pointless because of some twenty-year-old code in wxPython - expect the error "Unable to access the X Display, is $DISPLAY set properly?"~~

With the update to v0.10.37 and some minor changes to Amulet's source code, these two issues are now fixed:
- Wayland: I've implemented a brute-force override for Wayland users, and the modified code is in [my fork of Amulet](https://github.com/EvilSupahFly/Amulet-Map-Editor).
- Fix for textures: While I've modified [`download_resources.py`](https://github.com/EvilSupahFly/Minecraft-Model-Reader/blob/master/minecraft_model_reader/api/resource_pack/java/download_resources.py#L85) by adding a small `if` loop that examines the path requested, and modifies it if it doesn't match the Flatpak sandbox layout, this is not a permanent fix, as I still don't understand why the paths are being configured like this since even the experts on AskPython. For now, it does resolve the [missing textures](https://github.com/EvilSupahFly/Amulet-Flatpak/issues/7) the Flatpak release was experiencing much better than my last fix, as the textures are actually properly transparent now. I also increased the timeout period for texture pack downloads.

![Screenshot from 2024-08-15 23-04-29](https://github.com/user-attachments/assets/c9d42035-67e2-4f0a-8515-a325c0a36532)

If you're feeling ambitious, you can fork or clone this project and try tweaking it. For those brave souls who wish to try, I've written the [do_this.sh](https://github.com/EvilSupahFly/Amulet-Flatpak/blob/testing/do_this.sh) script to help you on your way with a `--help` switch you can pass for usage enlightenment.

The flatpak version has so far been tested on Manjaro, Ubuntu, Kubuntu and Mint. Feedback is most welcome!

I've found a work-around for Wayland users. The modified code is in [my fork of Amulet](https://github.com/EvilSupahFly/Amulet-Map-Editor). Possible side effect however: fonts **may** look like crap.

Fix for textures: I modified [`download_resources.py`](https://github.com/EvilSupahFly/Minecraft-Model-Reader/blob/master/minecraft_model_reader/api/resource_pack/java/download_resources.py#L85) by adding a small `if` loop that examines the path requested, and modifies it if it doesn't match the Flatpak sandbox layout.

This is not a permanent fix, as I still don't understand why the paths are being configured like this, but for now, it does resolve the [missing textures](https://github.com/EvilSupahFly/Amulet-Flatpak/issues/7) the Flatpak release was experiencing much better than my last fix, as the textures are actually properly transparent now. I also increased the timeout period for texture pack downloads.

README Last updated 01 December, 2024
README Last updated 02 December, 2024

0 comments on commit 178aeca

Please sign in to comment.