Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Creds Export Doesn't Escape Commas #285

Closed
leesoh opened this issue Jul 20, 2016 · 1 comment
Closed

Creds Export Doesn't Escape Commas #285

leesoh opened this issue Jul 20, 2016 · 1 comment

Comments

@leesoh
Copy link
Contributor

leesoh commented Jul 20, 2016

Empire Version

1.5.0

OS Information (Linux flavor, Python version)

Linux kali 4.4.0-kali1-amd64 #1 SMP Debian 4.4.6-1kali1 (2016-03-18) x86_64 GNU/Linux
Python 2.7.11+

Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.

Kind of a silly bug, but it's there and I saw it, so here we are. When exporting the credentials database to CSV, commas in the password field cause additional columns to be created in the resulting CSV. Suspect this can be escaped but haven't dug into it yet.
HarmJ0y added a commit that referenced this issue Jul 21, 2016
@HarmJ0y
Fix for issue #285 - credential export supporting commas
fe43560 
Start of code standardization/pep8 cleanup - mods to agents.py, empire.py, and credentials.py
Updated changelog
@HarmJ0y
Copy link
Contributor

HarmJ0y commented Jul 21, 2016

This should be fixed in the dev branch with fe43560 - all fields are now "" wrapped to prevent text commas from mucking up the csv format.

@HarmJ0y HarmJ0y closed this as completed Jul 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leesoh @HarmJ0y