Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElmerGrid, add reading Gmsh input format 4.1 in binary. Synchronize … #615

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

richb2k
Copy link
Contributor

@richb2k richb2k commented Dec 20, 2024

…with ElmerGui.

@richb2k
Copy link
Contributor Author

richb2k commented Dec 20, 2024

This PR is a further extension related to Issue #603 and PR #611. Add code to allow reading of Gmsh format 4.1 input files in binary format. Since there were a lot of changes to the function LoadGmshInput41, the function was reformatted with two column indentation.

@raback
Copy link
Contributor

raback commented Dec 20, 2024

Nice Rich! This saves disk space quite a bit for many. I never dared to even try. However, Xmas is approaching and nobody would be reverting here would something go wrong. So have to wait over the holidays with the merge. Merry Christmas to you!

@richb2k
Copy link
Contributor Author

richb2k commented Dec 20, 2024

Hello Peter and a Merry Christmas to you too!

No worries about waiting until next year, I don't think anyone is waiting for the changes. From doing some testing with a large case, the elmergrid binary read of the input msh file runs about twice as fast. There should also be a bit of a speed up of gmsh operation while writing the binary msh file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants