Add target to tagView + removeButton for delegate to work #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you like to add these methods in |
|
Why there, there is no logical connection between TagView and TagListView in terms of delegation of events. On the other hand, what we should do is to make sure that onTap methods can be applied as well instead of delegate. So every TagView should have - onTap (whole cell), onRemoveTap (remove button) and longPress event... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you create tagView instances and add them to tagList, delegate does not work.
And even if you try to attach selectors by yourself, removeButton is private property and you are not allowed to do so.
So I've added missing methods to tagListView to behave same as you add tags with :String