Custom tag views #143
Custom tag views #143
Conversation
TagListView/TagListView.swift
Outdated
|
|
||
|
|
||
| @discardableResult | ||
| open func stylize(tag tagView: TagView) -> TagView{ |
There was a problem hiding this comment.
I think tag is unnecessary here. Can you rename to stylize(_ tagView: TagView)? Also, there should be a space between TagView and {.
TagListView/TagListView.swift
Outdated
| @discardableResult | ||
| open func addTagViews(_ tagViews: [TagView]) -> [TagView] { | ||
| for tagView in tagViews { | ||
| self.tagViews.append(tagView) | ||
| tagBackgroundViews.append(UIView(frame: tagView.bounds)) | ||
| addTagView(tagView) |
There was a problem hiding this comment.
With the change, rearrangeViews() would be called tagViews.count times instead of one time. Can you address that?
There was a problem hiding this comment.
I addressed this in 892b412 by adding an extra argument to addTagView(_:) that specifies if it should call rearrangeViews(). It is true by default, so the impact to existing code both inside the library and in modules that imports it is 0. It's explicitly set to false inside this loop, and is called after the loop ends
… called when addTagView(_:) is called
|
👍 to the PR would love to see this one merged! |
|
@anti-transmission when do you think it will be release? :) |
|
I just pushed some commits to fix the previous merge conflicts with the latest |
This provides a fix for Issue #142. This moves the applying of default stylings from a factory method in
TagListViewthat's called inaddTag(_:)to a method that just handles styling and is called inaddTagView(_:)andinsertTagView(_:at:). I also changed the implementation ofaddTagViews(_:)to call out toaddTagView(_:)for each individual tag. Ultimately, this allows for the easy addition of custom subclasses toTagView. I added documentation comments for each of the relevant methods to make it clear that they unconditionally apply the styling of theTagListViewthat theTagView/subclass is being added to, so any individual tag stylization should take place after callingaddTagView(_:),addTagViews(_:), orinsertTagView(_:at:)