-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo of TagListView in a TableViewController #101
base: master
Are you sure you want to change the base?
Conversation
This pull request adds a a demo of a TagListView in a TableViewController. The pull request incorporates the pull requests for Bulk Add and Storyboard cleanup.
|
||
@IBAction func unwindToViewController(_ segue:UIStoryboardSegue) { | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should not have any trailing whitespace
} | ||
|
||
func tagRemoveButtonPressed(_ title: String, tagView: TagView, sender: TagListView) { | ||
print("Tag Remove pressed: \(title), \(sender)") | ||
sender.removeTagView(tagView) | ||
} | ||
|
||
@IBAction func unwindToViewController(_ segue:UIStoryboardSegue) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colon at column 50 should have exactly one space after it
} | ||
|
||
func tagRemoveButtonPressed(_ title: String, tagView: TagView, sender: TagListView) { | ||
print("Tag Remove pressed: \(title), \(sender)") | ||
sender.removeTagView(tagView) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should not have any trailing whitespace
// Dispose of any resources that can be recreated. | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should not have any trailing whitespace
@@ -33,7 +32,7 @@ class ViewController: UIViewController, TagListViewDelegate { | |||
tagView.onTap = { tagView in | |||
print("Don’t tap me!") | |||
} | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should not have any trailing whitespace
import UIKit | ||
|
||
class ViewController: UIViewController, TagListViewDelegate { | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should not have any trailing whitespace
setTags() | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should not have any trailing whitespace
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/ElaWorkshop/TagListView/pulls/101. |
import TagListView | ||
|
||
class TagsTableViewCell: UITableViewCell { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should not have any trailing whitespace
This pull request adds a a demo of a TagListView in a TableViewController.
The pull request incorporates the pull requests for Bulk Add (#100) and Storyboard cleanup (#94)