Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove adapter internal #3072

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove adapter internal #3072

wants to merge 5 commits into from

Conversation

meesvandongen
Copy link
Contributor

Type

  • Refactor

Description

Remove usage of adapter from internal code.

Related

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c3be920

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@effect/sql-sqlite-react-native Patch
@effect/platform-node-shared Patch
@effect/cluster-workflow Patch
@effect/platform-browser Patch
@effect/cluster-browser Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-wasm Patch
@effect/sql-sqlite-bun Patch
@effect/opentelemetry Patch
@effect/platform-node Patch
@effect/cluster-node Patch
@effect/experimental Patch
@effect/platform-bun Patch
@effect/sql-drizzle Patch
@effect/sql-mysql2 Patch
@effect/sql-mssql Patch
@effect/platform Patch
@effect/cluster Patch
@effect/printer Patch
effect Patch
@effect/schema Patch
@effect/sql-pg Patch
@effect/cli Patch
@effect/rpc Patch
@effect/sql Patch
@effect/rpc-http Patch
@effect/printer-ansi Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@meesvandongen
Copy link
Contributor Author

Note that there are still 1861 functions in spec files with function*($).

@tim-smart
Copy link
Contributor

Thanks! If you could add a patch changeset for this, as it touches implementation code.

@tim-smart
Copy link
Contributor

If you rebase against the latest main branch we can get this merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-smart tim-smart Awaiting requested review from tim-smart tim-smart is a code owner

@gcanti gcanti Awaiting requested review from gcanti

@IMax153 IMax153 Awaiting requested review from IMax153 IMax153 is a code owner

@mattiamanzati mattiamanzati Awaiting requested review from mattiamanzati mattiamanzati is a code owner

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Status: Discussion Ongoing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meesvandongen @tim-smart