Revert "DYN-7753: simplify file size string (#15629)"

This reverts commit 09aa203.
DynamoDS · Nov 12, 2024 · 15ad269 · 15ad269
1 parent 9ad38ee
commit 15ad269
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 68 deletions.
diff --git a/src/DynamoUtilities/PublicAPI.Unshipped.txt b/src/DynamoUtilities/PublicAPI.Unshipped.txt
@@ -234,7 +234,6 @@ static DynamoUtilities.PathHelper.IsValidPath(string filePath) -> bool
 static DynamoUtilities.PathHelper.isValidXML(string path, out System.Xml.XmlDocument xmlDoc, out System.Exception ex) -> bool
 static DynamoUtilities.PathHelper.LoadEmbeddedResourceAsString(string resourcePath, System.Reflection.Assembly assembly) -> string
 static DynamoUtilities.StringUtilities.CapitalizeFirstLetter(string word) -> string
-static DynamoUtilities.StringUtilities.SimplifyFileSizeUnit(string size) -> string
 static DynamoUtilities.TypeSwitch.Case<T>(System.Action action) -> DynamoUtilities.TypeSwitch.CaseInfo
 static DynamoUtilities.TypeSwitch.Case<T>(System.Action<T> action) -> DynamoUtilities.TypeSwitch.CaseInfo
 static DynamoUtilities.TypeSwitch.Default(System.Action action) -> DynamoUtilities.TypeSwitch.CaseInfo

diff --git a/src/DynamoUtilities/StringUtilities.cs b/src/DynamoUtilities/StringUtilities.cs
@@ -1,3 +1,9 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
 namespace DynamoUtilities
 {
     /// <summary>
@@ -17,20 +23,5 @@ public static string CapitalizeFirstLetter(string word)
 
             return char.ToUpper(word[0]) + word.Substring(1);
         }
-
-        /// <summary>
-        /// Replaces 'i' in a file size string
-        /// </summary>
-        /// <param name="size">The file size string</param>
-        /// <returns></returns>
-        public static string SimplifyFileSizeUnit(string size)
-        {
-            if (string.IsNullOrEmpty(size))
-            {
-                return size;
-            }
-
-            return size.Replace("i", "");
-        }
     }
 }
diff --git a/src/PackageDetailsViewExtension/PackageDetailItem.cs b/src/PackageDetailsViewExtension/PackageDetailItem.cs
@@ -5,7 +5,6 @@
 using Dynamo.Core;
 using Dynamo.PackageManager;
 using Dynamo.PythonServices;
-using DynamoUtilities;
 using Greg.Responses;
 
 namespace Dynamo.PackageDetails
@@ -284,7 +283,7 @@ public PackageDetailItem(string packageName, PackageVersion packageVersion, bool
             this.CopyRightYear = PackageVersion.copyright_year;
             this.CanInstall = canInstall;
             this.IsEnabledForInstall = isEnabledForInstall && canInstall;
-            this.PackageSize = string.IsNullOrEmpty(PackageVersion.size) ? "--" : StringUtilities.SimplifyFileSizeUnit (PackageVersion.size);
+            this.PackageSize = string.IsNullOrEmpty(PackageVersion.size) ? "--" : PackageVersion.size;
             this.Created = GetFormattedDate(PackageVersion.created);
             this.VersionInformation = GetFlattenedCompatibilityInformation(packageVersion.compatibility_matrix);
             this.ReleaseNotes = PackageVersion.release_notes_url;
@@ -316,7 +315,7 @@ public PackageDetailItem(List<VersionInformation> versionDetails, string package
             this.CopyRightYear = PackageVersion.copyright_year;
             this.CanInstall = canInstall;
             this.IsEnabledForInstall = isEnabledForInstall && canInstall;
-            this.PackageSize = string.IsNullOrEmpty(PackageVersion.size) ? "--" : StringUtilities.SimplifyFileSizeUnit (PackageVersion.size);
+            this.PackageSize = string.IsNullOrEmpty(PackageVersion.size) ? "--" : PackageVersion.size;
             this.Created = GetFormattedDate(PackageVersion.created);
             this.VersionInformation = GetFlattenedCompatibilityInformation(packageVersion.compatibility_matrix);
             this.IsCompatible = PackageManager.VersionInformation.GetVersionCompatibility(versionDetails, PackageVersionNumber);

diff --git a/test/DynamoCoreTests/StringUtilitiesTest.cs b/test/DynamoCoreTests/StringUtilitiesTest.cs