internal/uidriver/mobile: stop requesting a frame on gamepads

In general, it is impossible to treat gamepad inputtings as events. With FPSModeVsyncOffMinimum, the application cannot update with gamepad inputtings.
DmitryNaumov · Feb 4, 2022 · ee1b5e2 · ee1b5e2
1 parent 577b4ee
commit ee1b5e2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/internal/uidriver/mobile/gamepad_android.go b/internal/uidriver/mobile/gamepad_android.go
@@ -22,9 +22,6 @@ import (
 // UpdateGamepads is called when the gamepad states are given from outside like Android.
 func (u *UserInterface) UpdateGamepads(gamepads []Gamepad) {
 	u.input.updateGamepadsFromOutside(gamepads)
-	if u.fpsMode == driver.FPSModeVsyncOffMinimum {
-		u.renderRequester.RequestRenderIfNeeded()
-	}
 }
 
 func (i *Input) updateGamepadsFromOutside(gamepads []Gamepad) {

diff --git a/run.go b/run.go
@@ -362,7 +362,7 @@ const (
 	// FPSModeVsyncOffMinimum is useful for relatively static applications to save battery power.
 	//
 	// In FPSModeVsyncOffMinimum, the game's Update and Draw are called only when
-	// 1) new inputting is detected, or 2) ScheduleFrame is called.
+	// 1) new inputting except for gamepads is detected, or 2) ScheduleFrame is called.
 	// In FPSModeVsyncOffMinimum, TPS is SyncWithFPS no matter what TPS is specified at SetMaxTPS.
 	FPSModeVsyncOffMinimum FPSModeType = driver.FPSModeVsyncOffMinimum
 )