Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize deps with nested config #498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m0nch1
Copy link
Contributor

@m0nch1 m0nch1 commented Jun 30, 2024

The following WARN is displayed after pnpm install

image

Here is the PR to resolve this

And putting this fix in may also resolve issue: #473

reference

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.29%. Comparing base (479fbb2) to head (2061c38).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   42.31%   42.29%   -0.02%     
==========================================
  Files          26       26              
  Lines        1385     1388       +3     
  Branches      139      147       +8     
==========================================
+ Hits          586      587       +1     
- Misses        779      781       +2     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m0nch1 m0nch1 closed this Jul 5, 2024
@m0nch1 m0nch1 deleted the fix/optimise-nested branch July 5, 2024 13:55
@m0nch1 m0nch1 restored the fix/optimise-nested branch July 5, 2024 14:05
@m0nch1 m0nch1 reopened this Jul 5, 2024
@m0nch1 m0nch1 force-pushed the fix/optimise-nested branch from 2061c38 to 42b8377 Compare July 5, 2024 14:23
@m0nch1 m0nch1 marked this pull request as ready for review July 5, 2024 14:24
@m0nch1
Copy link
Contributor Author

m0nch1 commented Jul 6, 2024

@Diizzayy
I would appreciate it if you could review it when you have time!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant