Remove if (reason === crashed)

Although `crashed` has recently been updated to `render-process-gone`, the new params don't actually have to be used. In fact maybe allowing some of the other crash-ishes could result in weird invalid state and things happening. So basically I agree with atom#23132 (comment) Maybe there should be a different message for the `killed` reason though
DigDug101 · Oct 27, 2021 · b903148 · b903148
1 parent 6373c15
commit b903148
Showing 1 changed file with 24 additions and 29 deletions.
diff --git a/src/main-process/atom-window.js b/src/main-process/atom-window.js
@@ -236,37 +236,32 @@ module.exports = class AtomWindow extends EventEmitter {
       if (result.response === 0) this.browserWindow.destroy();
     });
 
-    this.browserWindow.webContents.on(
-      'render-process-gone',
-      async (event, { reason }) => {
-        if (reason === 'crashed') {
-          if (this.headless) {
-            console.log('Renderer process crashed, exiting');
-            this.atomApplication.exit(100);
-            return;
-          }
+    this.browserWindow.webContents.on('render-process-gone', async () => {
+      if (this.headless) {
+        console.log('Renderer process crashed, exiting');
+        this.atomApplication.exit(100);
+        return;
+      }
 
-          await this.fileRecoveryService.didCrashWindow(this);
-
-          const result = await dialog.showMessageBox(this.browserWindow, {
-            type: 'warning',
-            buttons: ['Close Window', 'Reload', 'Keep It Open'],
-            cancelId: 2, // Canceling should be the least destructive action
-            message: 'The editor has crashed',
-            detail: 'Please report this issue to https://github.com/atom/atom'
-          });
-
-          switch (result.response) {
-            case 0:
-              this.browserWindow.destroy();
-              break;
-            case 1:
-              this.browserWindow.reload();
-              break;
-          }
-        }
+      await this.fileRecoveryService.didCrashWindow(this);
+
+      const result = await dialog.showMessageBox(this.browserWindow, {
+        type: 'warning',
+        buttons: ['Close Window', 'Reload', 'Keep It Open'],
+        cancelId: 2, // Canceling should be the least destructive action
+        message: 'The editor has crashed',
+        detail: 'Please report this issue to https://github.com/atom/atom'
+      });
+
+      switch (result.response) {
+        case 0:
+          this.browserWindow.destroy();
+          break;
+        case 1:
+          this.browserWindow.reload();
+          break;
       }
-    );
+    });
 
     this.browserWindow.webContents.on('will-navigate', (event, url) => {
       if (url !== this.browserWindow.webContents.getURL())