fix busted tetss/functions

DetachHead · DetachHead · Feb 24, 2021 · Feb 24, 2021 · Feb 24, 2021 · Feb 25, 2021
commit b34999a9e487e40bd4dadfd0b6bdccc0e67beb98
diff --git a/src/utilityFunctions/Array.ts b/src/utilityFunctions/Array.ts
@@ -10,6 +10,7 @@ import {
 } from '../utilityTypes/Array'
 import { Narrow } from 'ts-toolbelt/out/Function/Narrow'
 import { Flatten } from 'ts-toolbelt/out/List/Flatten'
+import { orderBy } from 'lodash'
 
 /**
  * checks whether the given array's length is larger than **or equal to** the given number, and narrows the type of the
@@ -196,7 +197,7 @@ export function splice<
 	startIndex: StartIndex,
 	deleteCount: DeleteCount
 ): Splice<Array, StartIndex, DeleteCount> {
-	return array.splice(startIndex, deleteCount) as never
+	return array.filter((_, index) => index < startIndex || index > deleteCount + 1) as never
 }
 
 /**
@@ -235,5 +236,5 @@ export function indexOfLongestString<Strings extends string[]>(
 export function sortByLongestStrings<Strings extends string[]>(
 	strings: Narrow<Strings>
 ): SortLongestStrings<Strings> {
-	return strings.sort((string) => string.length) as never
+	return orderBy(strings, 'length', 'desc') as never
 }
diff --git a/src/utilityFunctions/__tests__/Number.spec.ts b/src/utilityFunctions/__tests__/Number.spec.ts
@@ -104,7 +104,7 @@ describe('comparison', () => {
 	describe('isGreaterThan', () => {
 		test('true', () => {
 			const value = isGreaterThan(5, 4) // $ExpectType true
-			assert(!value)
+			assert(value)
 		})
 		test('false', () => {
 			isGreaterThan(5, 20) // $ExpectType false