Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Filipino translations #583

Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat: Added Filipino translations #583

merged 4 commits into from
Sep 15, 2023

Conversation

kents00
Copy link
Contributor

@kents00 kents00 commented Sep 14, 2023 •
edited by DenverCoder1
Loading

Description

#236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-added-phil-9n08gy September 14, 2023 14:51 Inactive
DenverCoder1
DenverCoder1 reviewed Sep 14, 2023
View reviewed changes
src/translations.php Outdated Show resolved Hide resolved
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-added-phil-9n08gy September 15, 2023 08:28 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-added-phil-9n08gy September 15, 2023 08:48 Inactive
@DenverCoder1
Copy link
Owner

Looks great!

Same as with #582, there's one phrase that can still be translated to make it 100%. Let me know if you have any questions. Thanks!

image

@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-added-phil-9n08gy September 15, 2023 09:32 Inactive
DenverCoder1
DenverCoder1 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contributions 🎉

@DenverCoder1 DenverCoder1 changed the title Added Philippines translations feat: Added Filipino translations Sep 15, 2023
@DenverCoder1 DenverCoder1 merged commit 8586761 into DenverCoder1:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kents00 @DenverCoder1