@mrazauskas Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• jest — on npm, on unpkg (author is owner)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 64052,
  "author": "mrazauskas",
  "headCommitOid": "d7ce00d455f742beeb0d51d2ffb8af575a7e7532",
  "mergeBaseOid": "67b1826e657efe30626614f4bb5c6b918cd07fc9",
  "lastPushDate": "2023-01-24T17:47:25.000Z",
  "lastActivityDate": "2023-01-25T07:04:06.000Z",
  "mergeOfferDate": "2023-01-24T20:16:23.000Z",
  "mergeRequestDate": "2023-01-25T07:04:06.000Z",
  "mergeRequestUser": "mrazauskas",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jest/jest-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "NoHomey",
        "jwbay",
        "asvetliakov",
        "alexjoverm",
        "epicallan",
        "ikatyang",
        "wsmd",
        "JamieMason",
        "douglasduteil",
        "ahnpnl",
        "UselessPickles",
        "r3nya",
        "hotell",
        "sebald",
        "andys8",
        "antoinebrault",
        "gstamac",
        "ExE-Boss",
        "quassnoi",
        "Belco90",
        "tonyhallett",
        "ycmjason",
        "pawfa",
        "gerkindev",
        "domdomegg",
        "mrazauskas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sheetalkamat",
      "date": "2023-01-24T20:15:38.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1401965980,
  "ciResult": "pass"
}

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @pawfa @GerkinDev @domdomegg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@mrazauskas The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@mrazauskas The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@mrazauskas The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@mrazauskas can you give a quick explanation for why types/jest-when/index.d.ts needs to update Minimum TypeScript Version?

can you give a quick explanation for why types/jest-when/index.d.ts needs to update Minimum TypeScript Version?

Thanks for asking. Indeed I am not a fan to change TS version in so many packages. Here is the error pushing me to do so:

I looked for a work around with no luck so far. So decided to make the test pass and perhaps someone smarter than me will come up with a better solution.

@mrazauskas The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

And now CI gives: mapbox__aws-sdk-jest Out of memory: failed

My lucky day ;D Have to make a break.

Alright, thanks for the explanation. On behalf of the types of jest-when, I'm happy to approve when the CI passes

Unfortunately I can’t find a way to implement jest.replaceProperty(). Types copied from Jest repo gave this error:

As you can see from the commits, bumping the version as suggested leads to changing many other packages. After I bump version in all the packages, CI gave this:

As far as I know, there is no way to acquire more memory from GitHub. So I must leave jest.replaceProperty() for smarter than me.

@mrazauskas: Everything looks good here. I am ready to merge this PR (at d7ce00d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@NoHomey, @jwbay, @asvetliakov, @alexjoverm, @epicallan, @ikatyang, @wsmd, @JamieMason, @douglasduteil, @ahnpnl, @UselessPickles, @r3nya, @Hotell, @sebald, @andys8, @antoinebrault, @gstamac, @ExE-Boss, @quassnoi, @Belco90, @tonyhallett, @ycmjason, @pawfa, @GerkinDev, @domdomegg: you can do this too.)

Ready to merge