@someonewithpc Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• leaflet — on npm, on unpkg
  • 1 added owner: ✎@someonewithpc

@someonewithpc: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 61339,
  "author": "someonewithpc",
  "headCommitOid": "5ca069fa5d95e8b6b78ff7d4ce53899d8c918384",
  "mergeBaseOid": "935a0289ffea73f059baf4f501480a44543e45af",
  "lastPushDate": "2022-08-18T11:53:59.000Z",
  "lastActivityDate": "2022-09-15T20:34:55.000Z",
  "mergeOfferDate": "2022-09-15T20:21:31.000Z",
  "mergeRequestDate": "2022-09-15T20:34:55.000Z",
  "mergeRequestUser": "someonewithpc",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "leaflet",
      "kind": "edit",
      "files": [
        {
          "path": "types/leaflet/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/leaflet/leaflet-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alejo90",
        "atd-schubert",
        "mcauer",
        "ronikar",
        "life777",
        "henrythasler",
        "captain-igloo"
      ],
      "addedOwners": [
        "someonewithpc"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2022-09-15T20:20:46.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "dev4ndy",
      "date": "2022-08-18T21:39:16.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "oliverzm",
      "date": "2022-08-18T21:32:31.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1189534652,
  "ciResult": "pass"
}

🔔 @alejo90 @atd-schubert @mcauer @ronikar @life777 @henrythasler @captain-igloo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@someonewithpc The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@someonewithpc The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@someonewithpc The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

The tests on this package succeed, but some dependent packages fail. My TS skills aren't yet the best, so I'm currently struggling to fix the issues.

They seem to stem from the fact upstream added a export var Mixin = { Events: Events; } (here), which I tried to handle with this and this, but, while it doesn't produce errors in the local tests, it does in the ones in packages that depend on this one. Input would be greatly appreciated.

@someonewithpc The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@someonewithpc I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Aug 19th (in a week) if the issues aren't addressed.

All tests pass, but I wouldn't consider this the best way to do things. Namely:

• As I mentioned before, there are both L.Events and L.Evented where L.Evented extends both Class and Events, but I don't know how to express it
• L.geoJson is a deprecated alias of L.geoJSON, but I don't know how to express it
• L.noConflict should return the global L but I don't know how to express it

hello guys.
I was expecting to see the referrerpolicy property for TitleLayer, as it was added in Leaflet 1.8.0, and documented in the changelog

Is there any reason why this type property is not here as part of this PR?

Thanks for all the hard work you guys doing with this keeping the types up-to-date

^{Stricken elements don't seem to require changes on our part}

Leaflet ## 1.8.0 (2022-04-18) changelog:

⚠️ Breaking Changes

• Improve reliability of contextmenu event simulation on mobile Safari by introducing a new TapHold handler, replacing legacy Tap (#7026 by @johnd0e)
• Reorganize DivOverlay/Popup/Tooltip APIs (#7540 by @johnd0e)
  • Move Popup related options from DivOverlay to Popup (#7778 by @Falke-Design)
  • Change Tooltip class from leaflet-clickable to leaflet-interactive (#7719 by @Falke-Design)
  • Map.closeTooltip now requires a layer as argument ([Add redux-promise-middleware #7533](Map/closeTooltip: make argument not optional Leaflet/Leaflet#7533) by @johnd0e)
• Improve error / argument handling for event listeners (#7518 by @johnd0e)
• Improve reliability of touch events simulation on non-touch devices (DomEvent.Pointer) (#7059, #7084, #7415 by @johnd0e)
• Improve reliability of dblclick event simulation on touch devices (DomEvent.DoubleTap) (#7027 by @johnd0e)
• Improve reliability of disableClickPropagation (#7439 by @johnd0e)
• Improve Map hasLayer() and LayerGroup hasLayer() to require a layer as argument (#6999 by @johnd0e)
• Fix Class.include to not overwrite options (#7756 by @johnd0e)
• Fix Class.extend to not modify source props object (#6766 by @johnd0e)
• Improve Browser.touch touch devices detection (#7029 by @johnd0e)
• Get rid of legacy Android hacks (#7022 by @johnd0e)
• Allow fonts to respect users' browser settings by making the font-size relative to the map container. (You can change the font size on leaflet-container to adjust it if needed.) (#7800 by @Chandu-4444)

❇️ API changes

• Make DivOverlay / Tooltip interactive (#7531, #7532 by @johnd0e)
• Add openOn, close, toggle functions to DivOverlay (#6639 by @johnd0e)
• Introduce DomEvent.off(el) to remove all listeners (#7125 by @johnd0e)
• Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (#7100 by @johnd0e)
• Add autoPanOnFocus to Marker (#8042 by @IvanSanchez)
• Add referrerPolicy to TileLayer (#7945 by @natevw)
• Add playsInline to VideoOverlay (#7928 by @Falke-Design)
• Add getCenter to ImageOverlay (#7848 by @Falke-Design)
• Fire a tileabort event when a TileLayer load is cancelled (#6786 by @dstndstn)
• Add crossOrigin to Icon (#7298 by @syedmuhammadabid)

@oliverzm Thanks for the approval, but can you suggest a better way to structure the Events and Evented classes? I'm not happy with the current "solution", which is just to duplicate the code

Ready to merge