fix(52056): re-introduce v4 for webpack-terser-plugin #52062
Conversation
To allow using v4 not passthrough version the proper tsconfig needs to be in place and types be published with a change. Thanks! /cc @rchl Fixes: DefinitelyTyped#52056
typescript-bot
added
Popular package
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 52062,
"author": "peterblazejewicz",
"headCommitOid": "273eaaa1797d65f02a0b6d9b81f919197c8d9b48",
"lastPushDate": "2021-03-29T16:04:36.000Z",
"lastActivityDate": "2021-03-31T18:06:02.000Z",
"maintainerBlessed": false,
"mergeOfferDate": "2021-03-31T12:00:08.000Z",
"mergeRequestDate": "2021-03-31T18:06:02.000Z",
"mergeRequestUser": "peterblazejewicz",
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "terser-webpack-plugin",
"kind": "edit",
"files": [
{
"path": "types/terser-webpack-plugin/v4/index.d.ts",
"kind": "definition"
},
{
"path": "types/terser-webpack-plugin/v4/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/terser-webpack-plugin/v4/terser-webpack-plugin-tests.ts",
"kind": "test"
},
{
"path": "types/terser-webpack-plugin/v4/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/terser-webpack-plugin/v4/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Danscho",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Danscho",
"date": "2021-03-31T11:59:32.000Z",
"isMaintainer": false
}
],
"ciResult": "pass"
} |
|
🔔 @Danscho — please review this PR in the next few days. Be sure to explicitly select |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
typescript-bot
added
the
Perf: Same
typescript-bot
added
Owner Approved
|
@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at 273eaaa) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Danscho: you can do this too.) |
|
Ready to merge 💋 |
|
I just published |
To allow using v4 not passthrough version the proper tsconfig needs to
be in place and types be published with a change.
See #51712 for details.
Thanks!
/cc @rchl
Fixes: #52056
npm test <package to test>.how-to: