Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack] Remove @types/webpack; webpack@^5.0.0 bundles type definitions #51681

Closed
wants to merge 2 commits into from

Conversation

tjjfvi
Copy link

@tjjfvi tjjfvi commented Mar 11, 2021

This is marked as draft because there are still many errors; the majority of them, afaict, are due to webpack's type definitions relying on the presence of @types/node. I'm not sure what the proper way to mark the affected packages as requiring @types/node is, given that it's a dependency requirement, and not needed in the types themselves.

Once I know the proper way to add @types/node, I can do that in bulk and fix the remainder of the errors.

I noticed the existence of #49755, but that doesn't nearly update all the relevant packages, so I though it would be useful to open a PR with the relevant packages updated in bulk.


Please fill in this template.

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@tjjfvi
Copy link
Author

tjjfvi commented Mar 11, 2021

Ah, looking through the comments on #49755 more thoroughly, I see that there are some additional considerations to removing @types/webpack. I'm going to close this for now, though if webpack@4 is deprecated in the future, this might be a useful base to work off of.

@tjjfvi tjjfvi closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant