Swiper.destroy - fix for multi invocation of detachEvents() function

DavidLama · Apr 25, 2018 · 44ec90a · 44ec90a
1 parent e04796c
commit 44ec90a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/components/core/core-class.js b/src/components/core/core-class.js
@@ -343,6 +343,11 @@ class Swiper extends SwiperClass {
   destroy(deleteInstance = true, cleanStyles = true) {
     let swiper = this;
     const { params, $el, $wrapperEl, slides } = swiper;
+
+    if(typeof swiper.params === 'undefined'){
+      return true
+    }
+
     swiper.emit('beforeDestroy');
 
     // Init Flag

diff --git a/src/components/core/events/index.js b/src/components/core/events/index.js
@@ -61,10 +61,6 @@ function detachEvents() {
 
   const { params, touchEvents, el, wrapperEl } = swiper;
 
-  if(typeof params === 'undefined'){
-    return true
-  }
-
   const target = params.touchEventsTarget === 'container' ? el : wrapperEl;
   const capture = !!params.nested;