Calendar app: use instrumentation annotations #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a dependency on the `opentelemetry-instrumentation-annotations` library to use `@WithSpan` annotation. * Move `getDate` method to the `CalendarService` class. * Update OTel Java Agent to the latest `2.6.0` version
dineshg13
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@WithSpaninstrumentation annotations to the Calendar appio.opentelemetry.instrumentation:opentelemetry-instrumentation-annotations2.6.0of the OTel Java Agenthelminstructions in README)Motivation
QA Instructions
helminstructions from READMEBlast Radius
Changes introduced in the PR make following docs out of date: