Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert scheduler GetEligibleNodes optimization from issue #125336 #75

Merged

Conversation

domenicbozzuto
Copy link

@domenicbozzuto domenicbozzuto commented Sep 6, 2024

This is best reviewed commit-by-commit

This PR cherry picks a fix to issue 125336; in short, this resolves a scheduler bug where an attempted pre-optimization for a PreFilterPlugin would incorrectly assume a nodes name == kubernetes.io/hostname label on the pesistent volume associated with the node, so a pod using that PV would become unscheduleable.

This branch was created from release-1.28-dd-v1.28.11-dd.4 as a base. At the time of writing, the current version deployed in production is release-1.28-dd-v1.28.11-dd.1 The commits identified in the diff between these versions were deemed not worthy of including with this bugfix, and were reverted (first 4 commits).

The final commit reverts kubernetes@380c7f2; this is the PR responsible for introduce the GetEligibleNodes PreFilter optimization.

There is an open upstream PR to revert this: kubernetes#125398. Note that the upstream PR also introduces a unit test; I opted just to revert the single commit.

The revert was mostly clean, but required 10 conflicts to resolved in 5 files. Most of these were dealing with the deletion of the GetEligibleNodes method. I opted to manually git revert this vs. cherry-picking the fix that's open upstream because there were more conflicts (the upstream revert is based on 1.30 and also reverts much of the klog contextual logging changes that were shipped with 1.30)

go test ./pkg/scheduler                                                                                                                                                                                                                                                                
ok      k8s.io/kubernetes/pkg/scheduler 7.993s

@domenicbozzuto domenicbozzuto changed the title Cherry pick scheduler fix for issue #125336 Revert scheduler GetEligibleNodes optimization from issue #125336 Sep 6, 2024
@domenicbozzuto domenicbozzuto merged commit 40c5b2b into release-1.28-dd-v1.28.11-dd.5 Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants