Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(di): use the low-impact monitoring API #10993

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(di): use the low-impact monitoring API #10993

wants to merge 1 commit into from
+203 −2

Conversation

P403n1x87
Copy link
Contributor

We re-implement the wrapping context using the low-impact monitoring API introduced in Python 3.12.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CODEOWNERS have been resolved as:

.github/workflows/di-low-impact-monitoring-api-profile.yml              @DataDog/python-guild @DataDog/apm-core-python
scripts/profiles/di-low-impact-monitoring-api/run.py                    @DataDog/apm-core-python
scripts/profiles/di-low-impact-monitoring-api/run.sh                    @DataDog/apm-core-python
scripts/profiles/di-low-impact-monitoring-api/setup.sh                  @DataDog/apm-core-python
ddtrace/internal/wrapping/context.py                                    @DataDog/apm-core-python

@P403n1x87 P403n1x87 force-pushed the refactor/di-low-impact-monitoring-api branch from 3202890 to 7f4eda5 Compare October 9, 2024 14:15
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 9, 2024 •
edited
Loading

Datadog Report

Branch report: refactor/di-low-impact-monitoring-api
Commit report: 2bcbe12
Test service: dd-trace-py

✅ 0 Failed, 1054 Passed, 232 Skipped, 26m 19.93s Total duration (11m 25.67s time saved)

@P403n1x87 P403n1x87 force-pushed the refactor/di-low-impact-monitoring-api branch from 7f4eda5 to a410249 Compare October 9, 2024 14:42
@pr-commenter
Copy link

pr-commenter bot commented Oct 9, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-10-10 09:06:01

Comparing candidate commit 2bcbe12 in PR branch refactor/di-low-impact-monitoring-api with baseline commit f757fbf in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@P403n1x87 P403n1x87 force-pushed the refactor/di-low-impact-monitoring-api branch from a410249 to 5b9aeb9 Compare October 9, 2024 14:56
@P403n1x87
Copy link
Contributor Author

P403n1x87 commented Oct 10, 2024 •
edited
Loading

Native CPU profile

Screenshot 2024-10-10 at 09 16 15

@P403n1x87
refactor(di): use the low-impact monitoring API
2bcbe12 
We re-implement the wrapping context using the low-impact monitoring API
introduced in Python 3.12.
@P403n1x87 P403n1x87 force-pushed the refactor/di-low-impact-monitoring-api branch from 5b9aeb9 to 2bcbe12 Compare October 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@P403n1x87