Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flare): fix tracer flare #10985

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(flare): fix tracer flare #10985

wants to merge 2 commits into from

Conversation

erikayasuda
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/flare/_subscribers.py                                  @DataDog/apm-core-python
ddtrace/internal/flare/flare.py                                         @DataDog/apm-core-python
ddtrace/internal/flare/handler.py                                       @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 8, 2024 •
edited
Loading

Datadog Report

Branch report: erikayasuda/tracerflare-fix
Commit report: f7ec322
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 18m 36.75s Total duration (17m 55.86s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Oct 8, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-10-08 22:18:48

Comparing candidate commit f7ec322 in PR branch erikayasuda/tracerflare-fix with baseline commit 48c2a2c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikayasuda