fix(llmobs): recreate eval metric writer on fork [backport 2.12] #10765
+73
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5dbd7ef from #10710 to 2.12.
This PR ensures that the
LLMObsEvalMetricWriter
is correctly recreated and restarted on a forked process.Previously, on a process fork we were not recreating/restarting the eval metric writer worker.
Mirrors #10249 but for eval metric writer
Checklist
Reviewer Checklist